On 5 September 2011 11:51, Ian Romanick <span dir="ltr"><<a href="mailto:idr@freedesktop.org">idr@freedesktop.org</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"> -----BEGIN PGP SIGNED MESSAGE-----<br> Hash: SHA1<br> <div class="im"><br> On 09/04/2011 07:44 PM, Chia-I Wu wrote:<br> > Changes since v1 are<br> ><br> > - change how switch cases are guarded in piglit_get_gl_error_name<br> > - rename piglit-util-gles2.c to piglit-util-gles.c, and let GLES1 and<br> > GLES2 share it<br> > - hide enum naming differences in gl_wrap.h<br> > (e.g. define GL_TEXTURE_CUBE_MAP_POSITIVE_X to<br> > GL_TEXTURE_CUBE_MAP_POSITIVE_X_OES for GLES1)<br> > - call piglit_report_result(PIGLIT_SKIP) when piglit_require_GLSL or<br> > other shader related helpers are called in piglitutil_gles1<br> <br> </div>For the parts of the series that weren't already,<br> <br> Reviewed-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>><br> <br> -----BEGIN PGP SIGNATURE-----<br> Version: GnuPG v1.4.11 (GNU/Linux)<br> Comment: Using GnuPG with Fedora - <a href="http://enigmail.mozdev.org/" target="_blank">http://enigmail.mozdev.org/</a><br> <br> iEUEARECAAYFAk5lGjYACgkQX1gOwKyEAw/+3ACYgihsLK9gGgCUlhhdfnv7jzNR<br> UACdH9sy+IJ9R2gHQjxXjLVedNok3y4=<br> =BpTb<br> -----END PGP SIGNATURE-----<br> <div><div></div><div class="h5">_______________________________________________<br> Piglit mailing list<br> <a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a><br> <a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a><br> </div></div></blockquote></div><br>Chia-I: I was about to push these patches on your behalf, but I'm not 100% sure which versions are the right ones to push. I believe you should have push access to Piglit now--can you push these patches? Thanks.<br>