On 8 September 2011 17:52, Chia-I Wu <<a href="mailto:olvaffe@gmail.com">olvaffe@gmail.com</a>> wrote: <div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"> <div><div></div><div class="h5">On Fri, Sep 9, 2011 at 4:23 AM, Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>> wrote: > On 5 September 2011 11:51, Ian Romanick <<a href="mailto:idr@freedesktop.org">idr@freedesktop.org</a>> wrote: >> >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> On 09/04/2011 07:44 PM, Chia-I Wu wrote: >> > Changes since v1 are >> > >> > - change how switch cases are guarded in piglit_get_gl_error_name >> > - rename piglit-util-gles2.c to piglit-util-gles.c, and let GLES1 and >> > GLES2 share it >> > - hide enum naming differences in gl_wrap.h >> > (e.g. define GL_TEXTURE_CUBE_MAP_POSITIVE_X to >> > GL_TEXTURE_CUBE_MAP_POSITIVE_X_OES for GLES1) >> > - call piglit_report_result(PIGLIT_SKIP) when piglit_require_GLSL or >> > other shader related helpers are called in piglitutil_gles1 >> >> For the parts of the series that weren't already, >> >> Reviewed-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>> >> >> -----BEGIN PGP SIGNATURE----- >> Version: GnuPG v1.4.11 (GNU/Linux) >> Comment: Using GnuPG with Fedora - <a href="http://enigmail.mozdev.org/" target="_blank">http://enigmail.mozdev.org/</a> >> >> iEUEARECAAYFAk5lGjYACgkQX1gOwKyEAw/+3ACYgihsLK9gGgCUlhhdfnv7jzNR >> UACdH9sy+IJ9R2gHQjxXjLVedNok3y4= >> =BpTb >> -----END PGP SIGNATURE----- >> _______________________________________________ >> Piglit mailing list >> <a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a> >> <a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a> > > Chia-I: I was about to push these patches on your behalf, but I'm not 100% > sure which versions are the right ones to push. I believe you should have > push access to Piglit now--can you push these patches? Thanks. </div></div>The ones marked [PATCHv2 ..] should be pushed. I do not have push access to piglit. I should apply after I've created enough patches. -- olv@LunarG.com </blockquote></div> Ok, patches have been pushed. FWIW, I think you have enough patches under your belt to get Piglit access, so feel free to apply. (In fact, I was talking to Eric yesterday and he thought you already had access).