OK, great -- thanks for the help.<div><br></div><div>Stuart<br><br><div class="gmail_quote">On Tue, Sep 27, 2011 at 1:52 PM, Eric Anholt <span dir="ltr"><<a href="mailto:eric@anholt.net">eric@anholt.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
On Fri, 23 Sep 2011 17:05:17 -0700, Stuart Abercrombie <<a href="mailto:sabercrombie@chromium.org">sabercrombie@chromium.org</a>> wrote:<br>Non-text part: multipart/mixed<br>Non-text part: multipart/alternative<br><div class="im">
> shader_runner version attached.<br>><br>> I'm not aware of an application that directly illustrates the problem so I<br>> don't have a bug number. I was thinking with this test in piglit it would<br>
> be possible to file a bug.<br>><br>> Stuart<br><br></div>I've renamed the test to reflect more specifically where the bug was,<br>made the success color green instead of red (general convention in<br>piglit), and pushed it:<br>
<br>commit ca7dc479391402b1bd3ecf16f26ad42235611cf4<br>Author: Eric Anholt <<a href="mailto:eric@anholt.net">eric@anholt.net</a>><br>Date: Tue Sep 27 13:42:06 2011 -0700<br><br> glsl-varying-read: New test for a bug that was in i965 in 7.11.<br>
<br> The bug was already fixed as part of fixing the varying matrix array<br> access tests, but that only really happened due to a combination of<br> lowering passes, while this is much more specific.<br><br><br>... and oh crap I lost the author attribution. Sorry about that.<br>
<br>In the future, using git format-patch and git-send-email to send patches<br>means I don't have to 'git apply ~/whatever.patch; git add<br>tests/shaders/new_file.shader_test; git commit -a --author="Stuart<br>
Abercrombie <<a href="mailto:sabercrombie@chromium.org">sabercrombie@chromium.org</a>>"' to apply the patch with the<br>correct attribution.</blockquote></div></div>