On 14 October 2011 07:45, Brian Paul <<a href="mailto:brianp@vmware.com" target="_blank">brianp@vmware.com</a>> wrote: <div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div>On 10/13/2011 02:45 PM, Paul Berry wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> This patch fixes several version checks in glean that are too specific (e.g. checking that the GL version is 2.x or 3.x when the intent is to make sure the GL version is>= 2.0). We now perform the version check using the piglit-util functions piglit_is_gles() and piglit_get_gl_version() rather than manually inspecting the GL_VERSION string, so this makes the glean tests depend on the piglitutil library. </blockquote> </div> Hmmm, I think it would be cleaner if this was fixed in up-stream glean. It should be trivial to write a glean_get_gl_version(). Also, I don't think glean has ever been used with ES so I don't think we need to check for ES in the glean tests (or if we do, it should probably be done everywhere). I don't know when glean was last imported into piglit, but there have been some assorted fixes there. If you can develop a patch, I'd push it there for you. -Brian </blockquote></div> Oh, I didn't realize glean was being independently maintained. Sure, I'll develop a patch that can be submitted upstream. Where should I send it?