On 14 October 2011 14:33, Brian Paul <span dir="ltr"><<a href="mailto:brianp@vmware.com">brianp@vmware.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On 10/14/2011 02:15 PM, Paul Berry wrote:<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
On 14 October 2011 07:45, Brian Paul <<a href="mailto:brianp@vmware.com" target="_blank">brianp@vmware.com</a><br></div><div><div></div><div class="h5">
<mailto:<a href="mailto:brianp@vmware.com" target="_blank">brianp@vmware.com</a>>> wrote:<br>
<br>
On 10/13/2011 02:45 PM, Paul Berry wrote:<br>
<br>
This patch fixes several version checks in glean that are too<br>
specific<br>
(e.g. checking that the GL version is 2.x or 3.x when the<br>
intent is to<br>
make sure the GL version is>= 2.0).<br>
<br>
We now perform the version check using the piglit-util functions<br>
piglit_is_gles() and piglit_get_gl_version() rather than manually<br>
inspecting the GL_VERSION string, so this makes the glean<br>
tests depend<br>
on the piglitutil library.<br>
<br>
<br>
Hmmm, I think it would be cleaner if this was fixed in up-stream<br>
glean. It should be trivial to write a glean_get_gl_version().<br>
Also, I don't think glean has ever been used with ES so I don't<br>
think we need to check for ES in the glean tests (or if we do, it<br>
should probably be done everywhere).<br>
<br>
I don't know when glean was last imported into piglit, but there<br>
have been some assorted fixes there.<br>
<br>
If you can develop a patch, I'd push it there for you.<br>
<br>
-Brian<br>
<br>
<br>
Oh, I didn't realize glean was being independently maintained. Sure,<br>
I'll develop a patch that can be submitted upstream. Where should I<br>
send it?<br>
</div></div></blockquote>
<br>
<br>
There's a glean-dev list hosted on sourceforge. Otherwise, you can just send it to me and I'll push it.<br><font color="#888888">
<br>
-Brian<br>
</font></blockquote></div><br>Ok, I sent a patch to you. Are you planning to cherry-pick it over to Piglit or do you need me to do that?<br>