<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:p="urn:schemas-microsoft-com:office:powerpoint" xmlns:a="urn:schemas-microsoft-com:office:access" xmlns:dt="uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:s="uuid:BDC6E3F0-6DA3-11d1-A2A3-00AA00C14882" xmlns:rs="urn:schemas-microsoft-com:rowset" xmlns:z="#RowsetSchema" xmlns:b="urn:schemas-microsoft-com:office:publisher" xmlns:ss="urn:schemas-microsoft-com:office:spreadsheet" xmlns:c="urn:schemas-microsoft-com:office:component:spreadsheet" xmlns:odc="urn:schemas-microsoft-com:office:odc" xmlns:oa="urn:schemas-microsoft-com:office:activation" xmlns:html="http://www.w3.org/TR/REC-html40" xmlns:q="http://schemas.xmlsoap.org/soap/envelope/" xmlns:rtc="http://microsoft.com/officenet/conferencing" xmlns:D="DAV:" xmlns:Repl="http://schemas.microsoft.com/repl/" xmlns:mt="http://schemas.microsoft.com/sharepoint/soap/meetings/" xmlns:x2="http://schemas.microsoft.com/office/excel/2003/xml" xmlns:ppda="http://www.passport.com/NameSpace.xsd" xmlns:ois="http://schemas.microsoft.com/sharepoint/soap/ois/" xmlns:dir="http://schemas.microsoft.com/sharepoint/soap/directory/" xmlns:ds="http://www.w3.org/2000/09/xmldsig#" xmlns:dsp="http://schemas.microsoft.com/sharepoint/dsp" xmlns:udc="http://schemas.microsoft.com/data/udc" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:sub="http://schemas.microsoft.com/sharepoint/soap/2002/1/alerts/" xmlns:ec="http://www.w3.org/2001/04/xmlenc#" xmlns:sp="http://schemas.microsoft.com/sharepoint/" xmlns:sps="http://schemas.microsoft.com/sharepoint/soap/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:udcs="http://schemas.microsoft.com/data/udc/soap" xmlns:udcxf="http://schemas.microsoft.com/data/udc/xmlfile" xmlns:udcp2p="http://schemas.microsoft.com/data/udc/parttopart" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns:st="" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 12 (filtered medium)"><style></style></head><body lang=ZH-CN link=blue vlink=purple><div class=WordSection1><div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm'>From: Paul Berry [mailto:stereotype441@gmail.com] Sent: Wednesday, November 02, 2011 11:12 PM To: Zhao, Jian J Cc: piglit@lists.freedesktop.org Subject: Re: [Piglit] [PATCH] Test case on rendering with only fragment shader but no vertex shader.<o:p></o:p></div></div><o:p> </o:p>On 2 November 2011 02:07, Zhao, Jian J <<a href="mailto:jian.j.zhao@intel.com">jian.j.zhao@intel.com</a>> wrote:<o:p></o:p><div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm'><div><div>Hi Paul, <o:p></o:p>  Thanks for your suggestion.  My answer is inline. <o:p></o:p> <o:p></o:p>Best regards<o:p></o:p>ZhaoJian<o:p></o:p> <o:p></o:p><div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm'>From: Paul Berry [mailto:<a href="mailto:stereotype441@gmail.com" target="_blank">stereotype441@gmail.com</a>] Sent: Wednesday, November 02, 2011 12:20 AM To: Zhao, Jian J Cc: <a href="mailto:piglit@lists.freedesktop.org" target="_blank">piglit@lists.freedesktop.org</a> Subject: Re: [Piglit] [PATCH] Test case on rendering with only fragment shader but no vertex shader.<o:p></o:p></div></div><div> <o:p></o:p>Before I get to specific comments, are you familiar with Piglit's "shader runner" framework (look at any of the Piglit files that end in ".shader_test").  It seems like this test could be rewritten as a shader runner test--that would make it shorter and more readable, and save a compilation step.<o:p></o:p> <o:p></o:p></div>It’s a good idea. But unfortunately I can’t reproduce it with shader_runner, I have a look and find it is because it uses glDrawArraysInstancedARB instead of glDrawArrays or just simple glBegin and glEnd. I don’t know what is glDrawArraysInstancedARB. What’s it difference from glDrawArrays? So I just updated my original patch file. <o:p></o:p><div><o:p> </o:p></div></div></div></div></blockquote><div> You're right that it doesn't make sense to use glDrawArraysInstancedARB--that function is only available if your GL implementation supports the ARB_draw_instanced extension, or GL 3.1, and there's no good reason to make your test dependent on those.  (If you're curious, you can find documentation for the extension in <a href="http://www.opengl.org/registry/specs/ARB/draw_instanced.txt">http://www.opengl.org/registry/specs/ARB/draw_instanced.txt</a>.  When the extension was folded into GL 3.1, it was renamed to glDrawArraysInstanced). But shader_runner only tries to use glDrawArraysInstancedARB if your shader_test file contains the command "draw instanced rect".  You should be able to do the testing you need by just drawing a simple rectangle using the "draw rect" command, which works on GL 2.1. For an example of how this sort of test is typically written using shader_runner, see for instance tests/spec/glsl-1.10/execution/fs-inline-notequal.shader_test. Thanks very much for your patience with this--I really want to avoid having to add more compiled C programs to piglit if at all possible.<o:p></o:p><o:p> </o:p><o:p> </o:p>Hi Paul, <o:p></o:p>  Thanks very much for your explanation and help. And as Ian pointed out, the error is caused by some mistake in my test case. <o:p></o:p><o:p> </o:p>Best regards<o:p></o:p>ZhaoJian<o:p></o:p><o:p> </o:p></div></div></div></div></body></html>