On 10 November 2011 15:36, Chad Versace <<a href="mailto:chad.versace@linux.intel.com">chad.versace@linux.intel.com</a>> wrote: <div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 <div class="im"> On 11/10/2011 11:38 AM, Paul Berry wrote: > When the static-write-varying-01.frag tests were introduced, they were > accidentally made the same as the corresponding > static-write-varying-02.frag. > > The original intent (from talking to Chad) was for one set of tests > verify that varyings can't be written to via direct assignment, and > the other set of tests to verify that varyings can't be written to via > passing to a function as an "out" parameter. </div>Thanks for cleaning this up. There's a few silly mistakes in the tests. <div class="im"> > > This patch updates static-write-varying-01.frag to reflect the > original intent. > --- > .../storage-qualfiers/static-write-varying-01.frag | 6 +----- > .../storage-qualfiers/static-write-varying-01.frag | 6 +----- > .../storage-qualfiers/static-write-varying-01.frag | 6 +----- > 3 files changed, 3 insertions(+), 15 deletions(-) > > diff --git a/tests/spec/glsl-1.00/compiler/storage-qualfiers/static-write-varying-01.frag b/tests/spec/glsl-1.00/compiler/storage-qualfiers/static-write-varying-01.frag > index e5548c5..aedbc02 100644 > --- a/tests/spec/glsl-1.00/compiler/storage-qualfiers/static-write-varying-01.frag > +++ b/tests/spec/glsl-1.00/compiler/storage-qualfiers/static-write-varying-01.frag > @@ -10,10 +10,6 @@ > > varying float x; > > -void f(out float y) { > - y = 0.0; > -} > - > void g() { > - f(x); > + y = 0.0; > } </div>That should be x = 0.0. </blockquote><div> Argh, oops. Thanks for catching these. </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div class="im"> > diff --git a/tests/spec/glsl-1.10/compiler/storage-qualfiers/static-write-varying-01.frag b/tests/spec/glsl-1.10/compiler/storage-qualfiers/static-write-varying-01.frag > index 11b5834..48f54d0 100644 > --- a/tests/spec/glsl-1.10/compiler/storage-qualfiers/static-write-varying-01.frag > +++ b/tests/spec/glsl-1.10/compiler/storage-qualfiers/static-write-varying-01.frag > @@ -10,10 +10,6 @@ > > varying float x; > > -void f(out float y) { > - y = 0.0; > -} > - > void g() { > - f(x); > + x = 0.0; > } </div>Correct here. <div class="im"> > diff --git a/tests/spec/glsl-1.20/compiler/storage-qualfiers/static-write-varying-01.frag b/tests/spec/glsl-1.20/compiler/storage-qualfiers/static-write-varying-01.frag > index 1e03f27..ec832f9 100644 > --- a/tests/spec/glsl-1.20/compiler/storage-qualfiers/static-write-varying-01.frag > +++ b/tests/spec/glsl-1.20/compiler/storage-qualfiers/static-write-varying-01.frag > @@ -10,10 +10,6 @@ > > varying float x; > > -void f(out float y) { > - y = 0.0; > -} > - > void g() { > - f(x); > + y = 0.0; > } </div>This should be x = 0.0 too. Other than the little typos, this is Reviewec-by: Chad Versace <<a href="mailto:chad.versace@linux.intel.com">chad.versace@linux.intel.com</a>> - ---- Chad Versace <a href="mailto:chad.versace@linux.intel.com">chad.versace@linux.intel.com</a> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - <a href="http://enigmail.mozdev.org/" target="_blank">http://enigmail.mozdev.org/</a> iQIcBAEBAgAGBQJOvF/hAAoJEAIvNt057x8i+ekP+wauh7WPVERLOpL/W5dUNFXp 0hpKfRL5wa/K7h/YC6extOING0PLoWfh0CAlLC8N45oedbufN0p5Tu5q0eiNgmut +BqG5xL24qavM7Mt4EQ0Wg8s96D2j4qm94jq9iNVYAMYwxPmUaCvP9Gv33CEh/GN 1lko1xNActFCO68uFu/mUAP1Dp6DdjhFB4z8VjCOW/y2pv4lur2ma1HQkvK2hNDw jLI28oWwSX7ipHn/w0npX0D/ZeautLuK/pjMyDdIHuK74pW5tBGBJQgcWLGde4Ue TAvkGVQ9xs2970SLjLpQe4eDoHTSGDGUmh4C4tqANopvSyAUulKJhpMa+XA91tfm ihaKKpeXlARCI//bUDJV18AbgW6aRFCHLIKuqwoXzI0/sbZqoXAl6+WDK2LrCmRw CFTl8uoO1EAu07ARFLhSwWDgLiSAljNbXDktJeIFi8YSeAGVZdgG2TF2aGSaBW5e X8rRw+dvni9sz+de/ABLnWPPut3YPvoUCJ37aGbwejoq1v5xIaqPQlwnSbbH8M6D 05zjyO2ng/I2Z0esRgBVOb0GoDmSecM/N5wh9ZS1Nxh5UuUtmiqUhNoxElqFvxSz d+jyXdNuydvLzAA6dVMrNmGmnwI4v1JoihLxw3EqRWU3otnGmW/C5f1/xWmmKoV9 h8G1mj3SJGp08qmD2vME =2E8L -----END PGP SIGNATURE----- </blockquote></div>