On 19 January 2012 15:15, Ian Romanick <span dir="ltr"><<a href="mailto:idr@freedesktop.org">idr@freedesktop.org</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
From: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>><br>
<br>
The check occured too late in some invocations. This caused the test<br>
to fail on platforms that don't support EXT_transform_feedback when it<br>
should be skipped.<br>
<br>
Signed-off-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>><br>
---<br>
tests/spec/ext_transform_feedback/generatemipmap.c | 3 ++-<br>
1 files changed, 2 insertions(+), 1 deletions(-)<br>
<br>
diff --git a/tests/spec/ext_transform_feedback/generatemipmap.c b/tests/spec/ext_transform_feedback/generatemipmap.c<br>
index 1fe035c..2f16e1c 100644<br>
--- a/tests/spec/ext_transform_feedback/generatemipmap.c<br>
+++ b/tests/spec/ext_transform_feedback/generatemipmap.c<br>
@@ -274,10 +274,11 @@ void piglit_init(int argc, char **argv)<br>
else<br>
print_usage_and_exit(argv[0]);<br>
<br>
+ piglit_require_transform_feedback();<br>
+<br>
if (buffer || prims_written) {<br>
GLuint vs;<br>
piglit_require_GLSL();<br>
- piglit_require_transform_feedback();<br>
vs = piglit_compile_shader_text(GL_VERTEX_SHADER, vstext);<br>
xfb_prog = piglit_CreateProgram();<br>
piglit_AttachShader(xfb_prog, vs);<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.7.6.4<br>
<br>
_______________________________________________<br>
Piglit mailing list<br>
<a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a><br>
</font></span></blockquote></div><br>Oops. You're right of course.<br><br>Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br>