On Mon, Feb 13, 2012 at 11:40 AM, Patrick Baggett <span dir="ltr">&lt;<a href="mailto:baggett.patrick@gmail.com">baggett.patrick@gmail.com</a>&gt;</span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

Would it be more appropriate to compare the product of the width and height? e.g.<div><br></div><div> if (width * height &gt; decompress-&gt;Width* decompress-&gt;Height)</div></blockquote><div> </div><div>Yes, this looks more appropriate. Tested it with piglit quick.tests. No regressions.</div>

<div>Brian, do you have any comments on Patrick&#39;s suggestion?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><br><div class="gmail_quote"><div>

<div class="h5">On Mon, Feb 13, 2012 at 1:34 PM, Anuj Phogat <span dir="ltr">&lt;<a href="mailto:anuj.phogat@gmail.com" target="_blank">anuj.phogat@gmail.com</a>&gt;</span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">Reallocate/resize decompress FBO only if texture image width/height is<br>
greater than existing decompress FBO width/height.<br>
<br>
Signed-off-by: Anuj Phogat &lt;<a href="mailto:anuj.phogat@gmail.com" target="_blank">anuj.phogat@gmail.com</a>&gt;<br>
---<br>
 src/mesa/drivers/common/meta.c |    2 +-<br>
 1 files changed, 1 insertions(+), 1 deletions(-)<br>
<br>
diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c<br>
index f3f5d85..c3b2367 100644<br>
--- a/src/mesa/drivers/common/meta.c<br>
+++ b/src/mesa/drivers/common/meta.c<br>
@@ -3292,7 +3292,7 @@ decompress_texture_image(struct gl_context *ctx,<br>
    }<br>
<br>
    /* alloc dest surface */<br>
-   if (width != decompress-&gt;Width || height != decompress-&gt;Height) {<br>
+   if (width &gt; decompress-&gt;Width || height &gt; decompress-&gt;Height) {<br>
       _mesa_RenderbufferStorageEXT(GL_RENDERBUFFER_EXT, GL_RGBA,<br>
                                    width, height);<br>
       decompress-&gt;Width = width;<br>
</div></div><span class="HOEnZb"><font color="#888888"><span><font color="#888888">--<br>
1.7.7.6<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</font></span></font></span></blockquote></div><br></div>
</blockquote></div><br>