On 2 February 2012 05:27, Jose Fonseca <span dir="ltr"><<a href="mailto:jfonseca@vmware.com">jfonseca@vmware.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">----- Original Message -----<br>
> If you drop a file into asmparsertests/shaders, it's probably a new<br>
> ARB program you'd like tested. Eliminates the fuss of adding them to<br>
> all.tests, along with a lot of lines of pointless code.<br>
><br>
> Signed-off-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>><br>
> ---<br>
> tests/all.tests | 449<br>
> +-----------------------------------------------------<br>
> 1 files changed, 9 insertions(+), 440 deletions(-)<br>
><br>
> diff --git a/tests/all.tests b/tests/all.tests<br>
> index b48ef9a..5843080 100644<br>
> --- a/tests/all.tests<br>
> +++ b/tests/all.tests<br>
> @@ -4,6 +4,8 @@<br>
> import os<br>
> import os.path as path<br>
><br>
> +from glob import glob<br>
> +<br>
> from framework.core import *<br>
> from framework.exectest import *<br>
> from framework.gleantest import *<br>
> @@ -1609,445 +1611,13 @@ add_plain_test(hiz,<br>
</div>[...]<br>
<div class="im">> +# Add all the asmparsertests<br>
> +for lang in ('ARBvp1.0', 'ARBfp1.0'):<br>
> + for shader in glob(path.join('tests', 'asmparsertest', 'shaders',<br>
<br>
</div>Please use the testsDir variable instead of 'tests', to avoid breaking when PWD != top dir.<br>
<br>
Otherwise looks good. I think this is a nice cleanup.<br></blockquote><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span class="HOEnZb"><font color="#888888"><br>
Jose<br></font></span></blockquote><div><br>With Jose's suggested fix, this patch is:<br><br>Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br> </div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span class="HOEnZb"><font color="#888888">
</font></span><div class="HOEnZb"><div class="h5">_______________________________________________<br>
Piglit mailing list<br>
<a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a><br>
</div></div></blockquote></div><br>