On 16 March 2012 11:52, Chad Versace <span dir="ltr"><<a href="mailto:chad.versace@linux.intel.com">chad.versace@linux.intel.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On 03/12/2012 02:41 PM, Paul Berry wrote:<br>
> Previous patches set up the piglit-dispatch infrastructure but did not<br>
> use it. This patch enables piglit-dispatch and uses it instead of<br>
> GLEW.<br>
><br>
> No piglit regressions on Intel SandyBridge (Linux) or Mac OSX.<br>
<br>
</div>Nice. Only one more platform to conquer.<br>
<div class="im"><br>
> #if defined(USE_OPENGL)<br>
> -# include "glew.h"<br>
> - /* Include the real headers too, in case GLEW misses something. */<br>
> +# include "piglit-dispatch.h"<br>
> + /* Include the real headers too, in case piglit-dispatch misses something. */<br>
> # ifdef __APPLE__<br>
> # include <OpenGL/gl.h><br>
> # include <OpenGL/glu.h><br>
<br>
</div>Shouldn't Apple's <OpenGL/gl.h> be removed too?<br>
I think we discussed this before, but I don't remember the conclusion.<br></blockquote><div><br>Yes, you're right. In fact this whole block should be removed:<br><br> /* Include the real headers too, in case piglit-dispatch misses something. */<br>
# ifdef __APPLE__<br># include <OpenGL/gl.h><br># include <OpenGL/glu.h><br># include <OpenGL/glext.h><br># else<br># include <GL/gl.h><br># include <GL/glu.h><br>
# include <GL/glext.h><br># endif<br><br>I'll update the patch.<br><br></div></div>