On 3 May 2012 15:59, Chad Versace <span dir="ltr"><<a href="mailto:chad.versace@linux.intel.com" target="_blank">chad.versace@linux.intel.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA1<br>
<div class="im"><br>
On 05/02/2012 02:30 PM, Paul Berry wrote:<br>
> This patch adds a new test, "depthstencil-render-miplevels", which<br>
> verifies that we can render to all miplevels of depth and stencil<br>
> textures. It exposes two bugs in Mesa's current i965 driver:<br>
><br>
> - Miptree offsets aren't being calculated correctly for HiZ and<br>
> separate stencil buffers, causing miplevels to overlap in those<br>
> buffers.<br>
><br>
> - When binding the same texture to the GL_DEPTH_ATTACHMENT and<br>
> GL_STENCIL_ATTACHMENT points, Mesa is trying to share internal data<br>
> structures even if the miplevels don't match; as a result,<br>
> transitioning from one miplevel to another doesn't work.<br>
><br>
> The test is capable of running at any texture size (including<br>
> non-power-of-two texture sizes). However, because of some GPU hang<br>
> bugs in Mesa's current i965 driver, I've limited it to test at a<br>
> texture size of 1024x1024 for now.<br>
><br>
> v2: Added comment "/* Anonymous namespace */" on the final closing<br>
> brace. Adjusted the naming scheme for the subtests to allow<br>
> additional format combinations to be added in the future. Also added<br>
> format combinations involving z32f and z32f_s8.<br>
<br>
</div>Thanks for adding tests for the extra formats.<br>
<div class="im"><br>
> ---<br>
> tests/all.tests | 19 +<br>
> tests/texturing/CMakeLists.gl.txt | 1 +<br>
> tests/texturing/depthstencil-render-miplevels.cpp | 404 +++++++++++++++++++++<br>
> 3 files changed, 424 insertions(+), 0 deletions(-)<br>
> create mode 100644 tests/texturing/depthstencil-render-miplevels.cpp<br>
<br>
<br>
</div>[snip]<br>
<div class="im"><br>
> + * Usage: depthstencil-render-miplevels <texture_size> <buffer_combination><br>
> + *<br>
> + * buffer_combination: buffer attachments:<br>
> + * stencil stencil->DEPTH_STENCIL<br>
> + * depth_x depth->DEPTH_STENCIL<br>
> + * depth depth->DEPTH_COMPONENT<br>
> + * d16 depth->DEPTH_COMPONENT16<br>
> + * depth_x_and_stencil depth->DEPTH_STENCIL, stencil->DEPTH_STENCIL<br>
> + * stencil_and_depth_x (as above, but stencil attached first)<br>
> + * depth_and_stencil depth->DEPTH_COMPONENT, stencil->DEPTH_STENCIL<br>
> + * stencil_and_depth (as above, but stencil attached first)<br>
> + * depth_stencil_shared depth->DEPTH_STENCIL<-stencil<br>
> + * stencil_depth_shared (as above, but stencil attached first)<br>
> + * depth_stencil_single_binding depth_stencil->DEPTH_STENCIL<br>
<br>
</div>This comment needs to be updated.</blockquote><div><br>Whoops, you're right. I'll fix before pushing.<br></div></div>