On 9 May 2012 21:04, Anuj Phogat <span dir="ltr"><<a href="mailto:anuj.phogat@gmail.com" target="_blank">anuj.phogat@gmail.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>><br>
> I included this as sub test (only for color buffer blits) in a patch posted on May 7:<br>
> [PATCH] Add test to verify glBlitFramebuffer with multisample framebuffer objects.<br>
> In this patch, I am just clearing the multisample buffers to unique colors to do the testing.<br>
> This patch definitely require an update after the recent splitting of accuracy test. I would<br>
> love to see your comments to improve this patch.<br>
><br>
> Your patch looks better to me as it includes testing of depth and stencil buffer blits as well.<br>
> Keeping the clear color version of same test has no added advantage. So, I will exclude this<br>
> test case from the list of sub tests in above mentioned patch.<br></div></blockquote><div><br>Sorry, I forgot you had a test out on the mailing list that overlapped some of my test. I'll review your glBlitFramebuffer patch in more detail later this morning. My initial impression is that you're right--my test overlaps the functionality of test_blit_ms_ms_matching_samples() (and is more thorough, since it blits a complex pattern rather than a solid color). Definitely keep your other tests, though--it's good to check that GL errors are generated in the correct circumstances, and that no data is copied when a GL error occurs.<br>
</div>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>
><br>
> Reviewed-by: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com" target="_blank">anuj.phogat@gmail.com</a>><br>
<br>
</div>If you prefer to keep all multisample blitting cases in a single test,<br>
I am happy to merge the two patches<br>
and send it to the mailing list:<br>
1. [PATCH] Add test to verify glBlitFramebuffer with multisample<br>
framebuffer objects.<br>
2. [PATCH 1/2] Add a test of MSAA-to-MSAA blits.<br>
<br>
OR<br>
<br>
I will split my patch and post rest of the blitting cases as separate tests.<br></blockquote><div><br>In general I prefer splitting tests up, as long as it can be done without duplicating a lot of code. In my experience small tests that just do a few things are easier to debug than large tests that do a lot.<br>
</div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Thanks<br>
<span><font color="#888888">Anuj<br>
</font></span></blockquote></div><br>