On 16 July 2012 15:56, Anuj Phogat <span dir="ltr"><<a href="mailto:anuj.phogat@gmail.com" target="_blank">anuj.phogat@gmail.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
This test verifies that alpha values are not modified if<br>
GL_SAMPLE_ALPHA_TO_ONE is enabled and the buffer is single-sampled.<br>
<br>
Signed-off-by: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>><br>
---<br>
 tests/all.tests                                    |    6 +<br>
 .../ext_framebuffer_multisample/CMakeLists.gl.txt  |    2 +<br>
 .../alpha-to-one-single-sample-buffer.cpp          |  109 ++++++++++++++++++++<br>
 3 files changed, 117 insertions(+), 0 deletions(-)<br>
 create mode 100644 tests/spec/ext_framebuffer_multisample/alpha-to-one-single-sample-buffer.cpp<br>
<br>
diff --git a/tests/all.tests b/tests/all.tests<br>
index aeac4c1..27951bb 100644<br>
--- a/tests/all.tests<br>
+++ b/tests/all.tests<br>
@@ -1460,6 +1460,12 @@ for num_samples in MSAA_SAMPLE_COUNTS:<br>
         ext_framebuffer_multisample[test_name] = PlainExecTest(executable)<br>
<br>
 for num_samples in MSAA_SAMPLE_COUNTS:<br>
+        test_name = ' '.join(['alpha-to-one-single-sample-buffer', str(num_samples)])<br>
+        executable = 'ext_framebuffer_multisample-{0} -auto'.format(<br>
+                test_name)<br>
+        ext_framebuffer_multisample[test_name] = PlainExecTest(executable)<br>
+<br>
+for num_samples in MSAA_SAMPLE_COUNTS:<br>
         test_name = ' '.join(['bitmap', str(num_samples)])<br>
         executable = 'ext_framebuffer_multisample-{0} -auto'.format(<br>
                 test_name)<br>
diff --git a/tests/spec/ext_framebuffer_multisample/CMakeLists.gl.txt b/tests/spec/ext_framebuffer_multisample/CMakeLists.gl.txt<br>
index e51dfc2..ee12e68 100644<br>
--- a/tests/spec/ext_framebuffer_multisample/CMakeLists.gl.txt<br>
+++ b/tests/spec/ext_framebuffer_multisample/CMakeLists.gl.txt<br>
@@ -12,6 +12,8 @@ link_libraries (<br>
 piglit_add_executable (ext_framebuffer_multisample-accuracy common.cpp accuracy.cpp)<br>
 piglit_add_executable (ext_framebuffer_multisample-alpha-to-one-msaa-disabled common.cpp<br>
                       draw-buffers-common.cpp alpha-to-one-msaa-disabled.cpp)<br>
+piglit_add_executable (ext_framebuffer_multisample-alpha-to-one-single-sample-buffer common.cpp<br>
+                      draw-buffers-common.cpp alpha-to-one-single-sample-buffer.cpp)<br>
 piglit_add_executable (ext_framebuffer_multisample-bitmap common.cpp bitmap.cpp)<br>
 piglit_add_executable (ext_framebuffer_multisample-blit-mismatched-samples common.cpp blit-mismatched-samples.cpp)<br>
 piglit_add_executable (ext_framebuffer_multisample-blit-mismatched-sizes common.cpp blit-mismatched-sizes.cpp)<br>
diff --git a/tests/spec/ext_framebuffer_multisample/alpha-to-one-single-sample-buffer.cpp b/tests/spec/ext_framebuffer_multisample/alpha-to-one-single-sample-buffer.cpp<br>
new file mode 100644<br>
index 0000000..9143e83<br>
--- /dev/null<br>
+++ b/tests/spec/ext_framebuffer_multisample/alpha-to-one-single-sample-buffer.cpp<br>
@@ -0,0 +1,109 @@<br>
+/*<br>
+ * Copyright © 2012 Intel Corporation<br>
+ *<br>
+ * Permission is hereby granted, free of charge, to any person obtaining a<br>
+ * copy of this software and associated documentation files (the "Software"),<br>
+ * to deal in the Software without restriction, including without limitation<br>
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,<br>
+ * and/or sell copies of the Software, and to permit persons to whom the<br>
+ * Software is furnished to do so, subject to the following conditions:<br>
+ *<br>
+ * The above copyright notice and this permission notice (including the next<br>
+ * paragraph) shall be included in all copies or substantial portions of the<br>
+ * Software.<br>
+ *<br>
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR<br>
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,<br>
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL<br>
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER<br>
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING<br>
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS<br>
+ * IN THE SOFTWARE.<br>
+ */<br>
+<br>
+#include "draw-buffers-common.h"<br>
+<br>
+/**<br>
+ * \file alpha-to-one-single-sample-buffer.cpp<br>
+ *<br>
+ * Verify that alpha values are not modified if GL_SAMPLE_ALPHA_TO_ONE<br>
+ * is enabled and the buffer is single-sampled.<br>
+ *<br>
+ * This test operates by drawing a pattern in single sample FBO to generate<br>
+ * a reference and test image. Reference imag is drawn to the right half of<br>
+ * window system draw buffer and test image to the left half.<br>
+ *<br>
+ * Compare the left and right halves of window system frame buffer to verify<br>
+ * the test image.<br>
+ *<br>
+ * Author: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>><br>
+ */<br>
+<br>
+PIGLIT_GL_TEST_MAIN(256 /*window_width*/,<br>
+                   256 /*window_height*/,<br>
+                   GLUT_DOUBLE | GLUT_RGBA | GLUT_ALPHA)<br>
+<br>
+void<br>
+piglit_init(int argc, char **argv)<br>
+{<br>
+       const int num_attachments = 1;<br>
+       /* For single sample buffer */<br>
+       const int samples = 0;<br>
+<br>
+       piglit_require_gl_version(30);<br>
+<br>
+       int pattern_width = piglit_width / 2;<br>
+       int pattern_height = piglit_height / num_attachments;<br>
+<br>
+       piglit_ortho_projection(pattern_width,<br>
+                               pattern_height,<br>
+                               GL_TRUE);<br>
+<br>
+       /* Skip the test if samples > GL_MAX_SAMPLES */<br>
+       GLint max_samples;<br>
+       glGetIntegerv(GL_MAX_SAMPLES, &max_samples);<br>
+<br>
+       if (samples > max_samples)<br>
+               piglit_report_result(PIGLIT_SKIP);<br></blockquote><div><br>This check isn't necessary since samples == 0.  With that fixed, this patch is:<br><br>Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br>
 </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+<br>
+       ms_fbo_and_draw_buffers_setup(samples,<br>
+                                     pattern_width,<br>
+                                     pattern_height,<br>
+                                     num_attachments,<br>
+                                     GL_COLOR_BUFFER_BIT,<br>
+                                     GL_RGBA);<br>
+       shader_compile();<br>
+}<br>
+<br>
+enum piglit_result<br>
+piglit_display()<br>
+{<br>
+       bool pass = true;<br>
+       glBindFramebuffer(GL_DRAW_FRAMEBUFFER, 0);<br>
+       glClearColor(0.0, 0.0, 0.0, 1.0);<br>
+       glClear(GL_COLOR_BUFFER_BIT);<br>
+       allocate_data_arrays();<br>
+<br>
+       /* Set sample_alpha_to_one = false to generate reference image */<br>
+       draw_reference_image(false /* sample_alpha_to_coverage */,<br>
+                            false /* sample_alpha_to_one */);<br>
+<br>
+       draw_test_image(false /* sample_alpha_to_coverage */,<br>
+                       true /* sample_alpha_to_one */);<br>
+<br>
+       pass = piglit_check_gl_error(GL_NO_ERROR) && pass;<br>
+<br>
+       glBindFramebuffer(GL_READ_FRAMEBUFFER, 0);<br>
+       pass = piglit_probe_rect_halves_equal_rgba(0, 0,<br>
+                                                  piglit_width,<br>
+                                                  piglit_height)<br>
+              && pass;<br>
+<br>
+       /* Free the memory allocated for data arrays */<br>
+       free_data_arrays();<br>
+<br>
+       if (!piglit_automatic)<br>
+               piglit_present_results();<br>
+<br>
+       return pass ? PIGLIT_PASS : PIGLIT_FAIL;<br>
+}<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.7.7.6<br>
<br>
</font></span></blockquote></div><br>