On 16 July 2012 15:39,  <span dir="ltr"><<a href="mailto:anuj.phogat@gmail.com" target="_blank">anuj.phogat@gmail.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
From: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>><br>
<br>
Anuj Phogat (12):<br>
  msaa: Share visualize_image function by moving it to common.cpp<br>
  msaa: Add files containing the shared code to test multiple draw buffers<br>
  msaa: Add test to verify sample-alpha-to-one with multiple draw buffers<br>
  msaa: Add test to verify sample-alpha-to-coverage with multiple draw buffers<br>
  msaa: Add test to verify sample-alpha-to-one with integer draw buffers<br>
  msaa: Add test to verify sample-alpha-to-coverage with integer draw buffers<br>
  msaa: Add test to verify sample-alpha-to-one with GL_MULTISAMPLE disabled<br>
  msaa: Add test to verify sample-alpha-to-one with single sample FBO<br>
  msaa: Rewrite sample-alpha-to-coverage test to utilize the shared code<br>
  msaa: Rewrite sample-alpha-to-one test to utilize shared code<br>
  msaa: Add depth buffer testing support in draw-buffer-common.cpp<br>
  msaa: Add depth buffer testing to sample-alpha-to-coverage test case<br></blockquote><div><br>I made comments on patches 1, 8, and 12.  The rest are<br><br>Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br>
 </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
 tests/all.tests                                    |   41 +-<br>
 .../ext_framebuffer_multisample/CMakeLists.gl.txt  |   18 +-<br>
 .../alpha-to-one-msaa-disabled.cpp                 |  129 ++++<br>
 .../alpha-to-one-single-sample-buffer.cpp          |  109 +++<br>
 tests/spec/ext_framebuffer_multisample/common.cpp  |   84 ++<br>
 tests/spec/ext_framebuffer_multisample/common.h    |    5 +<br>
 .../draw-buffers-alpha-to-coverage.cpp             |  139 ++++<br>
 .../draw-buffers-alpha-to-one.cpp                  |  152 ++++<br>
 .../draw-buffers-common.cpp                        |  795 ++++++++++++++++++++<br>
 .../draw-buffers-common.h                          |   66 ++<br>
 tests/spec/ext_framebuffer_multisample/formats.cpp |   77 +--<br>
 .../int-draw-buffers-alpha-to-coverage.cpp         |  132 ++++<br>
 .../int-draw-buffers-alpha-to-one.cpp              |  129 ++++<br>
 .../sample-alpha-to-coverage.cpp                   |  389 ++--------<br>
 .../sample-alpha-to-one.cpp                        |  256 ++------<br>
 15 files changed, 1913 insertions(+), 608 deletions(-)<br>
 create mode 100644 tests/spec/ext_framebuffer_multisample/alpha-to-one-msaa-disabled.cpp<br>
 create mode 100644 tests/spec/ext_framebuffer_multisample/alpha-to-one-single-sample-buffer.cpp<br>
 create mode 100644 tests/spec/ext_framebuffer_multisample/draw-buffers-alpha-to-coverage.cpp<br>
 create mode 100644 tests/spec/ext_framebuffer_multisample/draw-buffers-alpha-to-one.cpp<br>
 create mode 100644 tests/spec/ext_framebuffer_multisample/draw-buffers-common.cpp<br>
 create mode 100644 tests/spec/ext_framebuffer_multisample/draw-buffers-common.h<br>
 create mode 100644 tests/spec/ext_framebuffer_multisample/int-draw-buffers-alpha-to-coverage.cpp<br>
 create mode 100644 tests/spec/ext_framebuffer_multisample/int-draw-buffers-alpha-to-one.cpp<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
1.7.7.6<br>
<br>
</font></span></blockquote></div><br>