On 25 August 2012 15:46, Chris Forbes <<a href="mailto:chrisf@ijw.co.nz" target="_blank">chrisf@ijw.co.nz</a>> wrote: <div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div class="im">> feel free to upload the patch to a publicly accessible > git repo and send out a link. </div>Pushed to `fboify` branch at git://<a href="http://github.com/chrisforbes/piglit.git" target="_blank">github.com/chrisforbes/piglit.git</a> -- Chris </blockquote></div> Excellent, thanks. Patch 1/6 ("Convert all glutSwapBuffers to piglit_present_results") look good except that we need to back out this change: diff --git a/tests/general/read-front.c b/tests/general/read-front.c index 2e999ba..bb0f301 100644 --- a/tests/general/read-front.c +++ b/tests/general/read-front.c @@ -58,7 +58,7 @@ piglit_display(void) glReadBuffer(GL_FRONT); - glutSwapBuffers(); + piglit_present_results(); pass &= piglit_probe_rect_rgb(0, 0, piglit_width, piglit_height / 2, blue); The reason read-front.c needs to call glutSwapBuffers() is because it is testing that after glutSwapBuffers(), the correct pixels can be read out of the front buffer. So the call to glutSwapBuffers() needs to happen no matter how the test is run. With that change backed out, patch 1/6 is: Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>> I've already sent comments on your other patches. Very nice work--I look forward to seeing v2 of the series, and I'll be glad to commit it upstream once everything gets reviewed (feel free to remind me if I forget).