On 30 November 2012 10:14, Ian Romanick <<a href="mailto:idr@freedesktop.org" target="_blank">idr@freedesktop.org</a>> wrote: <div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> From: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>> Currently on Mesa's gles3 branch this leads to an assertion failure. It works correctly on Mesa master and known Mesa releases. Signed-off-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>> </blockquote><div> When I apply this patch to Piglit master and run it using piglit-run.py, I get the following error: File "/home/pberry/.platform/piglit-mesa/piglit/source/framework/core.py", line 445, in doRun result = self.run(env.valgrind) File "/home/pberry/.platform/piglit-mesa/piglit/source/framework/exectest.py", line 63, in run if self.command is not None: File "/home/pberry/.platform/piglit-mesa/piglit/source/framework/glsl_parser_test.py", line 375, in command self.config.get('config', 'glsl_version') File "/usr/lib/python2.7/ConfigParser.py", line 618, in get raise NoOptionError(option, section) I think you need to add the line "* glsl_version: 1.10" to the [config] section. With that fixed, this is: Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> --- I'm not sure this is the right place for this test script to live. It didn't seem to fit in any of the existing subdirectories, and I was feeling too lazy to make a name for a new one. Suggestions? </blockquote><div> Personally, I'm fine with putting it in glsl-1.10, since that's where we put all the other tests that should be run no matter what version of GLSL is supported. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> tests/spec/glsl-1.10/compiler/invalid-version.vert | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 tests/spec/glsl-1.10/compiler/invalid-version.vert diff --git a/tests/spec/glsl-1.10/compiler/invalid-version.vert b/tests/spec/glsl-1.10/compiler/invalid-version.vert new file mode 100644 index 0000000..7dece33 --- /dev/null +++ b/tests/spec/glsl-1.10/compiler/invalid-version.vert @@ -0,0 +1,10 @@ +/* [config] + * expect_result: fail + * [end config] + */ +#version 999 + +void main() +{ + gl_Position = vec4(0.); +} -- 1.7.11.7 _______________________________________________ Piglit mailing list <a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a> </blockquote></div> </div>