<div dir="ltr">That makes sense, I'll post a V2 soon.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Mar 4, 2013 at 2:29 PM, Ken Phillis Jr <span dir="ltr"><<a href="mailto:kphillisjr@gmail.com" target="_blank">kphillisjr@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">As I stated in another email, It'll probably be a good idea to allow<br>
the deprecated behavior for a few more months, and instead print a<br>
warning message when users attempt to use deprecated options.<br>
<div><div class="h5"><br>
On Sat, Mar 2, 2013 at 6:00 PM, Dylan Baker <<a href="mailto:baker.dylan.c@gmail.com">baker.dylan.c@gmail.com</a>> wrote:<br>
> Excluding tests already uses a similar syntax (--exclude-tests), so this<br>
> is more consistent.<br>
><br>
> Signed-off-by: Dylan Baker <<a href="mailto:baker.dylan.c@gmail.com">baker.dylan.c@gmail.com</a>><br>
> ---<br>
> piglit-print-commands.py | 6 +++---<br>
> piglit-run.py | 6 +++---<br>
> 2 files changed, 6 insertions(+), 6 deletions(-)<br>
><br>
> diff --git a/piglit-print-commands.py b/piglit-print-commands.py<br>
> index 7a3ba14..c01248b 100755<br>
> --- a/piglit-print-commands.py<br>
> +++ b/piglit-print-commands.py<br>
> @@ -48,7 +48,7 @@ Prints a list of all the tests and how to run them. Ex:<br>
><br>
> Options:<br>
> -h, --help Show this message<br>
> - -t regexp, --tests=regexp Run only matching tests (can be used more<br>
> + -t regexp, --include-tests=regexp Run only matching tests (can be used more<br>
> than once)<br>
> -x regexp, --exclude-tests=regexp Exclude matching tests (can be used<br>
> more than once)<br>
> @@ -70,7 +70,7 @@ def main():<br>
> try:<br>
> option_list = [<br>
> "help",<br>
> - "tests=",<br>
> + "include-tests=",<br>
> "exclude-tests=",<br>
> ]<br>
> options, args = getopt(sys.argv[1:], "ht:x:", option_list)<br>
> @@ -85,7 +85,7 @@ def main():<br>
> for name, value in options:<br>
> if name in ('-h', '--help'):<br>
> usage()<br>
> - elif name in ('-t', '--tests'):<br>
> + elif name in ('-t', '--include-tests'):<br>
> test_filter.append(value)<br>
> env.filter.append(re.compile(value))<br>
> elif name in ('-x', '--exclude-tests'):<br>
> diff --git a/piglit-run.py b/piglit-run.py<br>
> index 8da99a0..0ab8fc6 100755<br>
> --- a/piglit-run.py<br>
> +++ b/piglit-run.py<br>
> @@ -45,7 +45,7 @@ Usage: %(progName)s [options] [profile.tests] [results]<br>
> Options:<br>
> -h, --help Show this message<br>
> -d, --dry-run Do not execute the tests<br>
> - -t regexp, --tests=regexp Run only matching tests (can be used more<br>
> + -t regexp, --include-tests=regexp Run only matching tests (can be used more<br>
> than once)<br>
> -x regexp, --exclude-tests=regexp Excludey matching tests (can be used<br>
> more than once)<br>
> @@ -81,7 +81,7 @@ def main():<br>
> "dry-run",<br>
> "resume",<br>
> "valgrind",<br>
> - "tests=",<br>
> + "include-tests=",<br>
> "name=",<br>
> "exclude-tests=",<br>
> "concurrent=",<br>
> @@ -106,7 +106,7 @@ def main():<br>
> OptionResume = True<br>
> elif name in ('--valgrind'):<br>
> env.valgrind = True<br>
> - elif name in ('-t', '--tests'):<br>
> + elif name in ('-t', '--include-tests'):<br>
> test_filter.append(value)<br>
> env.filter.append(re.compile(value))<br>
> elif name in ('-x', '--exclude-tests'):<br>
> --<br>
> 1.8.1.2<br>
><br>
</div></div>> _______________________________________________<br>
> Piglit mailing list<br>
> <a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a><br>
> <a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a><br>
</blockquote></div><br></div>