<div dir="ltr">On 8 April 2013 10:18, Eric Anholt <span dir="ltr"><<a href="mailto:eric@anholt.net" target="_blank">eric@anholt.net</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5">Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>> writes:<br>
> +     switch (test_mode) {<br>
> +     case TEST_MODE_GENERATED:<br>
> +             glBeginQuery(GL_PRIMITIVES_GENERATED, query);<br>
> +             glBeginTransformFeedback(GL_TRIANGLES);<br>
> +             glDrawElements(GL_TRIANGLE_STRIP, 9, GL_UNSIGNED_BYTE, NULL);<br>
> +             glEndTransformFeedback();<br>
> +             glEndQuery(GL_PRIMITIVES_GENERATED);<br>
> +             pass = check_query_result(query, 4);<br>
> +             break;<br>
> +     case TEST_MODE_WRITTEN:<br>
> +             glBeginQuery(GL_PRIMITIVES_GENERATED, query);<br></div></div></blockquote><div><br></div><div>Crap, I just noticed that the line above is supposed to be GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN.  I'll fix that.<br>
</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
> +             glBeginTransformFeedback(GL_TRIANGLES);<br>
> +             glDrawElements(GL_TRIANGLE_STRIP, 9, GL_UNSIGNED_BYTE, NULL);<br>
> +             glEndTransformFeedback();<br>
> +             glEndQuery(GL_PRIMITIVES_GENERATED);<br></div></div></blockquote><div><br></div><div>Same fix here too.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5">
> +             pass = check_query_result(query, 4);<br>
> +             break;<br>
> +     case TEST_MODE_FLUSH:<br>
> +             glBeginTransformFeedback(GL_TRIANGLES);<br>
> +             glDrawElements(GL_TRIANGLE_STRIP, 9, GL_UNSIGNED_BYTE, NULL);<br>
> +             glFlush();<br>
> +             glDrawElements(GL_TRIANGLE_STRIP, 4, GL_UNSIGNED_BYTE,<br>
> +                            (void *) (9 * sizeof(GLubyte)));<br>
> +             glEndTransformFeedback();<br>
> +             pass = check_xfb_result();<br>
> +             break;<br>
<br>
</div></div>I'd like to see this path also check_query_result -- I think we've got a<br>
better way to change the driver, but I worry about messing up the<br>
queries.  Other than that, looks good to me.<br>
<br>
</blockquote></div><br></div><div class="gmail_extra">(We talked about this in person, just keeping the list up to date).  Unfortunately, there's a snag with that: this test is trying to exercise a Mesa/i965 bug which only occurs when transform feedback is active and no queries are in progress.  So if we made that change the bug would go into hiding again.<br>
</div></div>