<div dir="ltr">On 3 June 2013 15:52, Chad Versace <span dir="ltr"><<a href="mailto:chad.versace@linux.intel.com" target="_blank">chad.versace@linux.intel.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="im">On 05/31/2013 12:50 PM, Paul Berry wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
When running tests with a non-composited window manager, it isn't safe<br>
to access the front buffer until after the window is shown.  This<br>
patch sets config.requires_displayed_<u></u>window in tests that access front<br>
buffers, to make sure that the piglit framework exposes the window,<br>
even when testing in "-auto" mode.<br>
---<br>
  tests/bugs/drawbuffer-modes.c | 1 +<br>
  tests/fbo/fbo-sys-blit.c      | 1 +<br>
  tests/fbo/fbo-sys-sub-blit.c  | 1 +<br>
  tests/general/masked-clear.c  | 1 +<br>
  4 files changed, 4 insertions(+)<br>
</blockquote>
<br>
<br>
<br>
<br>
<br>
<br>
</div><div class="im"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
diff --git a/tests/general/masked-clear.c b/tests/general/masked-clear.c<br>
index fdf81ba..21fe944 100644<br>
--- a/tests/general/masked-clear.c<br>
+++ b/tests/general/masked-clear.c<br>
@@ -39,6 +39,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN<br>
                                PIGLIT_GL_VISUAL_DEPTH |<br>
                                PIGLIT_GL_VISUAL_STENCIL |<br>
                                PIGLIT_GL_VISUAL_DOUBLE);<br>
+       config.requires_displayed_<u></u>window = true;<br>
  PIGLIT_GL_TEST_CONFIG_END<br>
</blockquote>
<br></div>
Indentation weirdness in masked-clear.c.<br></blockquote><div><br></div><div>I'm pretty sure it's properly indented.  Here's the hunk with more context:<br><br>diff --git a/tests/general/masked-clear.c b/tests/general/masked-clear.c<br>
index fdf81ba..21fe944 100644<br>--- a/tests/general/masked-clear.c<br>+++ b/tests/general/masked-clear.c<br>@@ -35,14 +35,15 @@<br> <br> PIGLIT_GL_TEST_CONFIG_BEGIN<br>        config.supports_gl_compat_version = 10;<br>        config.window_visual = (PIGLIT_GL_VISUAL_RGB |<br>
                                PIGLIT_GL_VISUAL_DEPTH |<br>                                PIGLIT_GL_VISUAL_STENCIL |<br>                                PIGLIT_GL_VISUAL_DOUBLE);<br>+       config.requires_displayed_window = true;<br>
 PIGLIT_GL_TEST_CONFIG_END<br> <br> <br> static void<br> failRGB(GLint chan, GLfloat expected,<br>        GLfloat actual, GLenum buffer)<br> {<br><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">

<br>
Other than that, patch 1 is<br>
Reviewed-by: Chad Versace <<a href="mailto:chad.versace@linux.intel.com" target="_blank">chad.versace@linux.intel.com</a>><br>
<br>
<br>
</blockquote></div><br></div></div>