<div dir="ltr">On 10 June 2013 16:54, Eric Anholt <span dir="ltr"><<a href="mailto:eric@anholt.net" target="_blank">eric@anholt.net</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class="im">Fabian Bieler <<a href="mailto:fabianbieler@fastmail.fm">fabianbieler@fastmail.fm</a>> writes:<br>
<br>
> Add primitives with adjacency and (for extreme future-proofness) patches to<br>
> recognized drawing modes.<br>
> ---<br>
>  tests/shaders/shader_runner.c | 7 ++++++-<br>
>  1 file changed, 6 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c<br>
> index 515fde1..e022b90 100644<br>
> --- a/tests/shaders/shader_runner.c<br>
> +++ b/tests/shaders/shader_runner.c<br>
> @@ -1481,8 +1481,13 @@ GLenum<br>
>  decode_drawing_mode(const char *mode_str)<br>
>  {<br>
>       int i;<br>
> +#ifdef PIGLIT_USE_OPENGL<br>
> +     const GLenum max_prim_type = GL_PATCHES;<br>
> +#else<br>
> +     const GLenum max_prim_type = GL_POLYGON;<br>
> +#endif<br>
<br>
</div>Both GLES2/3 and desktop enums should be available in both builds now,<br>
so no need for ifdefs -- just always use GL_PATCHES.<br></blockquote><div><br></div><div>Actually, Eric's series that allows this (<a href="http://lists.freedesktop.org/archives/piglit/2013-June/005927.html">http://lists.freedesktop.org/archives/piglit/2013-June/005927.html</a>) hasn't landed yet.  So if you take this suggestion, wait for Eric to land his series first.<br>
<br></div><div>With or without Eric's suggested change, this patch is:<br><br>Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">

<br>_______________________________________________<br>
Piglit mailing list<br>
<a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a><br>
<br></blockquote></div><br></div></div>