<div dir="ltr"><div>I'll send out different formatting for V2.<br><br></div>FWIW, the problem with these lines for me, is that I work with two terminals side be side, which means my terminals are exactly 80 characters wide, so anything over that is impossible to read. I know, first world problems.<br>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jul 22, 2013 at 2:32 PM, Chad Versace <span dir="ltr"><<a href="mailto:chad.versace@linux.intel.com" target="_blank">chad.versace@linux.intel.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 07/10/2013 03:19 PM, Dylan Baker wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
generated_tests/gen_uniform_<u></u>initializer_tests.py | 61 ++++++++++++++----------<br>
1 file changed, 35 insertions(+), 26 deletions(-)<br>
<br>
diff --git a/generated_tests/gen_uniform_<u></u>initializer_tests.py b/generated_tests/gen_uniform_<u></u>initializer_tests.py<br>
index dbb798d..f4bddcc 100644<br>
--- a/generated_tests/gen_uniform_<u></u>initializer_tests.py<br>
+++ b/generated_tests/gen_uniform_<u></u>initializer_tests.py<br>
@@ -54,16 +54,21 @@ def get_value(type, idx):<br>
def generate_tests(type_list, base_name, major, minor):<br>
for target in ("vs", "fs"):<br>
for t in all_templates:<br>
- template_file_name = "uniform-initializer-<u></u>templates/{0}-initializer{1}.<u></u>template".format(target, t)<br>
+ template_file_name = (<br>
+ "uniform-initializer-<u></u>templates/{0}-initializer{1}.<u></u>template"<br>
+ .format(target, t))<br>
</blockquote>
<br>
<br></div>
The original was understandable. The new formatting is significantly more difficult to read.<div class="im"><br>
<br>
<br>
test_file_name = dirname = os.path.join('spec',<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- 'glsl-{0}.{1}'.format(major, minor),<br>
+ 'glsl-{0}.{1}'<br>
+ .format(major, minor),<br>
'execution',<br>
'uniform-initializer',<br>
- '{0}-{1}{2}.shader_test'.<u></u>format(target, base_name, t))<br>
+ '{0}-{1}{2}.shader_test'<br>
+ .format(target, base_name,<br>
+ t))<br>
</blockquote>
<br>
<br></div>
The original was understandable. The new formatting is significantly more difficult to read.<div class="im"><br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
def generate_array_tests(type_<u></u>list, base_name, major, minor):<br>
for target in ("vs", "fs"):<br>
- template_file_name = "uniform-initializer-<u></u>templates/{0}-initializer.<u></u>template".format(target)<br>
+ template_file_name = \<br>
+ "uniform-initializer-<u></u>templates/{0}-initializer.<u></u>template".format(<br>
+ target)<br>
</blockquote>
<br>
<br></div>
The original was understandable. The new formatting is significantly more difficult to read.<div class="im"><br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
test_file_name = dirname = os.path.join('spec',<br>
- 'glsl-{0}.{1}'.format(major, minor),<br>
+ 'glsl-{0}.{1}'.format(major,<br>
+ minor),<br>
'execution',<br>
'uniform-initializer',<br>
- '{0}-{1}-array.shader_test'.<u></u>format(target, base_name))<br>
+ '{0}-{1}-array.shader_test'<br>
+ .format(target, base_name))<br>
</blockquote>
<br>
<br></div>
The original was understandable. The new formatting is significantly more difficult to read.<br>
<br>
<br>
If I didn't complain about it, then I thought it looked good.<br>
<br>
<br>
</blockquote></div><br></div>