<div dir="ltr">On 6 August 2013 21:33, Matt Turner <span dir="ltr"><<a href="mailto:mattst88@gmail.com" target="_blank">mattst88@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
generated_tests/gen_texture_query_lod_tests.py | 9 +++++----<br>
1 file changed, 5 insertions(+), 4 deletions(-)<br></blockquote><div><br></div><div>A quick note in the commit message explaining the rationale for this patch would be nice. (I assume you're doing this because without it, the tests that get generated for GLSL 4.00 don't have anything in their pathname to identify them as textureQueryLod tests).<br>
<br>In any case, the series is:<br><br>Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
diff --git a/generated_tests/gen_texture_query_lod_tests.py b/generated_tests/gen_texture_query_lod_tests.py<br>
index 1341f7d..be30a69 100755<br>
--- a/generated_tests/gen_texture_query_lod_tests.py<br>
+++ b/generated_tests/gen_texture_query_lod_tests.py<br>
@@ -112,6 +112,8 @@ template = Template(dedent("""\<br>
"""))<br>
<br>
for api, requirement in requirements.iteritems():<br>
+ Lod = 'Lod' if api == 'glsl-4.00' else 'LOD'<br>
+<br>
for sampler_type, coord_type in sampler_type_to_coord_type.iteritems():<br>
for execution_stage in ("vs", "fs"):<br>
file_extension = 'frag' if execution_stage == 'fs' else 'vert'<br>
@@ -119,8 +121,9 @@ for api, requirement in requirements.iteritems():<br>
api,<br>
"compiler",<br>
"built-in-functions",<br>
- "{0}.{1}".format(sampler_type,<br>
- file_extension))<br>
+ "textureQuery{0}-{1}.{2}".format(Lod,<br>
+ sampler_type,<br>
+ file_extension))<br>
print filename<br>
<br>
dirname = os.path.dirname(filename)<br>
@@ -137,8 +140,6 @@ for api, requirement in requirements.iteritems():<br>
'usamplerCubeArray', 'samplerCubeArrayShadow']:<br>
extensions += ['GL_ARB_texture_cube_map_array']<br>
<br>
- Lod = 'Lod' if api == 'glsl-4.00' else 'LOD'<br>
-<br>
f = open(filename, "w")<br>
f.write(template.render(version=version,<br>
extensions=extensions,<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.8.1.5<br>
<br>
_______________________________________________<br>
Piglit mailing list<br>
<a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a><br>
</font></span></blockquote></div><br></div></div>