<div dir="ltr"><div>Looks good.<br><br></div>Reviewed-by: Dylan Baker <<a href="mailto:baker.dylan.c@gmail.com">baker.dylan.c@gmail.com</a>><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Aug 12, 2013 at 2:54 PM, Kenneth Graunke <span dir="ltr"><<a href="mailto:kenneth@whitecape.org" target="_blank">kenneth@whitecape.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">If the Python framework fails to run a program for some reason, it'll<br>
record a 'fail' status. It also records a 'traceback' key in the<br>
dictionary.<br>
<br>
The new summary code missed this when writing the test detail page,<br>
resulting in tests marked as 'fail' with no indication as to why.<br>
<br>
Cc: Dylan Baker <<a href="mailto:baker.dylan.c@gmail.com">baker.dylan.c@gmail.com</a>><br>
Signed-off-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>><br>
---<br>
framework/summary.py | 1 +<br>
templates/test_result.mako | 7 +++++++<br>
2 files changed, 8 insertions(+)<br>
<br>
diff --git a/framework/summary.py b/framework/summary.py<br>
index 003728a..35500bf 100644<br>
--- a/framework/summary.py<br>
+++ b/framework/summary.py<br>
@@ -545,6 +545,7 @@ class Summary:<br>
returncode=value.get('returncode', 'None'),<br>
time=value.get('time', 'None'),<br>
info=value.get('info', 'None'),<br>
+ traceback=value.get('traceback', 'None'),<br>
command=value.get('command', 'None'),<br>
css=path.relpath(resultCss, tPath),<br>
index=index))<br>
diff --git a/templates/test_result.mako b/templates/test_result.mako<br>
index 12cb081..410dbb4 100644<br>
--- a/templates/test_result.mako<br>
+++ b/templates/test_result.mako<br>
@@ -40,6 +40,13 @@<br>
</pre>${command}</pre><br>
</td><br>
</tr><br>
+ <tr><br>
+ <td>Traceback</td><br>
+ <td><br>
+ <pre>${traceback}</pre><br>
+ </td><br>
+ </tr><br>
+<br>
</table><br>
<p><a href="${index}">Back to summary</a></p><br>
</body><br>
<span class="HOEnZb"><font color="#888888">--<br>
1.8.3.4<br>
<br>
</font></span></blockquote></div><br></div>