<div dir="ltr">On 7 August 2013 12:47, Jacob Penner <span dir="ltr"><<a href="mailto:jkpenner91@gmail.com" target="_blank">jkpenner91@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Add the following test to all.test, previously were missing.<br>
section test name<br>
arb_draw_elements_base_vertex 'draw-range-elements-base-vertex'<br>
'multi-draw-elements-base-vertex'<br>
arb_vertex_array_bgra 'arb_vertex_array_bgra'<br>
---<br>
tests/all.tests | 6 ++++++<br>
1 file changed, 6 insertions(+)<br>
<br>
diff --git a/tests/all.tests b/tests/all.tests<br>
index 39ee624..2bd3fd3 100644<br>
--- a/tests/all.tests<br>
+++ b/tests/all.tests<br>
@@ -1015,6 +1015,10 @@ add_plain_test(arb_draw_elements_base_vertex, 'draw-elements-base-vertex-bounds'<br>
arb_draw_elements_base_vertex['draw-elements-base-vertex-neg-user_varrays'] = PlainExecTest(['draw-elements-base-vertex-neg', '-auto', 'user_varrays'])<br>
add_plain_test(arb_draw_elements_base_vertex, 'draw-elements-instanced-base-vertex')<br>
arb_draw_elements_base_vertex['draw-elements-instanced-base-vertex-user_varrays'] = PlainExecTest(['draw-elements-instanced-base-vertex', '-auto', 'user_varrays'])<br>
+add_plain_test(arb_draw_elements_base_vertex, 'draw-range-elements-base-vertex')<br>
+arb_draw_elements_base_vertex['draw-range-elements-base-vertex-user_varrays'] = PlainExecTest(['draw-range-elements-base-vertex', '-auto', 'user_varrays'])<br>
+add_plain_test(arb_draw_elements_base_vertex, 'multi-draw-elements-base-vertex')<br>
+arb_draw_elements_base_vertex['multi-draw-elements-base-vertex-user_varrays'] = PlainExecTest(['multi-draw-elements-base-qvertex', '-auto', 'user_varrays'])<br></blockquote><div><br></div>
<div>There are a few problems here:<br><br>1. There's an extra 'q' in the last line which prevents the test "multi-draw-elements-base-vertex-user_varrays" from being able to run.<br><br></div><div>2. draw-range-elements-base-vertex and multi-draw-elements-base-vertex ignore their command line arguments, so the two "user_varrays" tests are redundant. For now I would recommend just dropping the "user_varrays" tests. We can add that functionality in a later patch.<br>
</div><div><br></div><div>3. multi-draw-elements-base-vertex crashes when run with Mesa, since it calls piglit_ortho_projection(), which tries to make use of compatibility-mode-only functionality. I think you can just drop this call from the test.<br>
<br></div><div>4. multi-draw-elements-base-vertex has some type errors which cause it to send the wrong data to the GL implementation on 64-bit systems. However, this is kind of a lucky mistake since it exposes a Mesa bug (it causes an assertion failure). So before we fix this, we should file a bug report so we don't forget to track down the Mesa bug. I'll show you the details when I see you later today.<br>
<br></div><div>BTW, 3 and 4 should have been caught during an earlier code review--sorry about that.<br><br></div><div>I think we should probably address 3 and 4 before landing this patch--is that ok with you?<br></div><div>
</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
# Group ARB_draw_instanced<br>
arb_draw_instanced = Group()<br>
@@ -1399,6 +1403,8 @@ add_plain_test(apple_vertex_array_object, 'vao-02')<br>
apple_vertex_array_object['isvertexarray'] = concurrent_test('arb_vertex_array-isvertexarray apple')<br>
<br>
profile.test_list['ARB_vertex_array_bgra/api-errors'] = PlainExecTest('arb_vertex_array_bgra-api-errors -auto')<br>
+profile.test_list['ARB_vertex_array_bgra/vertex-array-bgra'] = PlainExecTest('arb_vertex_array_bgra -auto')<br>
+<br>
<br>
arb_vertex_array_object = Group()<br>
spec['ARB_vertex_array_object'] = arb_vertex_array_object<br>
<span><font color="#888888">--<br>
1.8.3.1<br>
<br>
_______________________________________________<br>
Piglit mailing list<br>
<a href="mailto:Piglit@lists.freedesktop.org" target="_blank">Piglit@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a><br>
</font></span></blockquote></div><br></div></div>