<div dir="ltr">On 20 August 2013 10:56, Nicholas Mack <<a href="mailto:nichmack@gmail.com" target="_blank">nichmack@gmail.com</a>> wrote: <div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> Note: The spec refers to QUADS_FOLLOW_PROVOKING_VERTEX but this is a spec bug. --- tests/spec/arb_provoking_vertex/CMakeLists.gl.txt | 1 + .../quads-follow-provoking-vertex.c | 64 ++++++++++++++++++++++ 2 files changed, 65 insertions(+) create mode 100644 tests/spec/arb_provoking_vertex/quads-follow-provoking-vertex.c </blockquote><div> </div><div>I'm sorry, I led you astray by adding this to our list of test cases that need to be written. It turns out that it was a mistake that QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION ever got included in the core 3.2 spec in the first place, because it's impossible to render quads in the core profile. This got fixed in OpenGL 3.3. </div><div>Generally when there is something like this that's clearly a bug in a core spec, and it gets fixed in a later version of the spec, we try to implement the "fixed" behaviour. I think we should do so in this case too. Can we replace this patch with a test that instead verifies that glGetBooleanv(GL_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION, ...) produces an INVALID_ENUM error? </div><div>(Note: it looks like Mesa currently doesn't produce that error--that's a Mesa bug). </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> diff --git a/tests/spec/arb_provoking_vertex/CMakeLists.gl.txt b/tests/spec/arb_provoking_vertex/CMakeLists.gl.txt index cdcd99f..a5ebff9 100644 --- a/tests/spec/arb_provoking_vertex/CMakeLists.gl.txt +++ b/tests/spec/arb_provoking_vertex/CMakeLists.gl.txt @@ -11,5 +11,6 @@ link_libraries ( piglit_add_executable (arb-provoking-vertex-control provoking-vertex-control.c) piglit_add_executable (arb-provoking-vertex-initial provoking-vertex-initial.c) +piglit_add_executable (arb-quads-follow-provoking-vertex quads-follow-provoking-vertex.c) # vim: ft=cmake: diff --git a/tests/spec/arb_provoking_vertex/quads-follow-provoking-vertex.c b/tests/spec/arb_provoking_vertex/quads-follow-provoking-vertex.c new file mode 100644 index 0000000..7270236 --- /dev/null +++ b/tests/spec/arb_provoking_vertex/quads-follow-provoking-vertex.c @@ -0,0 +1,64 @@ +/** + * Copyright © 2013 Intel Corporation + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the "Software"), + * to deal in the Software without restriction, including without limitation + * the rights to use, copy, modify, merge, publish, distribute, sublicense, + * and/or sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice (including the next + * paragraph) shall be included in all copies or substantial portions of the + * Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + */ + +/** + * QUADS_FOLLOW_PROVOKING_VERTEX was added to GL 3.2 spec + * + * Table 6.45 of GL 3.2 core spec includes QUADS_FOLLOW_PROVOKING_VERTEX + * which can be queried with GetBooleanv() to see "Whether quads follow + * provoking vertex convention" + * + * NOTE: Spec incorrectly uses QUADS_FOLLOW_PROVOKING_VERTEX instead of + * QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION. + * See <a href="https://cvs.khronos.org/bugzilla/show_bug.cgi?id=8432" target="_blank">https://cvs.khronos.org/bugzilla/show_bug.cgi?id=8432</a> + * + */ + +#include "piglit-util-gl-common.h" + +PIGLIT_GL_TEST_CONFIG_BEGIN + + config.supports_gl_compat_version = 32; + config.supports_gl_core_version = 32; + +PIGLIT_GL_TEST_CONFIG_END + +void +piglit_init(int argc, char **argv) +{ + bool pass = true; + GLboolean followsProvoking = false; + + glGetBooleanv(GL_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION, + &followsProvoking); + + pass = piglit_check_gl_error(GL_NO_ERROR) && pass; + + piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL); +} + +enum piglit_result +piglit_display(void) +{ + return PIGLIT_FAIL; +} -- 1.8.3.1 _______________________________________________ Piglit mailing list <a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a> </blockquote></div> </div></div>