<div dir="ltr">On 28 August 2013 09:36, Eric Anholt <span dir="ltr"><<a href="mailto:eric@anholt.net" target="_blank">eric@anholt.net</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Bonus points if<br>
you drop the ifdefs around the calls to glVertexPointer() and<br>
glEnableVertexAttribArray() and friends -- piglit_dispatch means they're<br>
always available to be linked against, even if the implementation<br>
doesn't have them.<br></blockquote><div><br></div><div>I thought this was the case too, and I nearly made a comment to this effect when I reviewed this patch yesterday, but I tried it and it didn't work.  When compiling the gles1 target:<br>
<br>/home/pberry/piglit/tests/util/piglit-util-gl-common.c: In function ‘piglit_draw_rect_from_arrays’:<br>/home/pberry/piglit/tests/util/piglit-util-gl-common.c:687:220: error: called object is not a function or function pointer<br>
    glVertexAttribPointer(PIGLIT_ATTRIB_POS, 4, GL_FLOAT,<br>                                                                                                                                                                                                                            ^<br>
<br></div><div>I haven't investigated why this happens.<br></div></div></div></div>