<div dir="ltr">On 20 September 2013 12:31, Nicholas Mack <<a href="mailto:nichmack@gmail.com" target="_blank">nichmack@gmail.com</a>> wrote: <div class="gmail_extra"><div class="gmail_quote"> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">--- ...-layout-qualifiers-with-variable-declarations.geom | 19 +++++++++++++++++++ ...-layout-qualifiers-with-variable-declarations.geom | 19 +++++++++++++++++++ 2 files changed, 38 insertions(+) create mode 100644 tests/spec/glsl-1.50/compiler/incorrect-in-layout-qualifiers-with-variable-declarations.geom create mode 100644 tests/spec/glsl-1.50/compiler/incorrect-out-layout-qualifiers-with-variable-declarations.geom diff --git a/tests/spec/glsl-1.50/compiler/incorrect-in-layout-qualifiers-with-variable-declarations.geom b/tests/spec/glsl-1.50/compiler/incorrect-in-layout-qualifiers-with-variable-declarations.geom new file mode 100644 index 0000000..f26b60d --- /dev/null +++ b/tests/spec/glsl-1.50/compiler/incorrect-in-layout-qualifiers-with-variable-declarations.geom @@ -0,0 +1,19 @@ +// [config] +// expect_result: fail +// glsl_version: 1.50 +// check_link: true </blockquote><div> </div><div>This needs to be "check_link: false". Otherwise the test will erroneously pass due to lacking the necessary input/output layout qualifiers. A similar change needs to be made to incorrect-out-layout-qualifiers-with-variable-declarations.geom. </div><div>With that change, this patch is: </div><div>Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>> </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> +// [end config] +// +// Tests that input layout qualifiers cannot be used on a variable declaration. +// +// GLSLangSpec 1.50, section 4.3.8.2 (Output Layout Qualifiers): +// "Geometry shaders allow input layout qualifiers only on the interface +// qualifier in, not on an input block,block member, or variable." + +#version 150 + +layout(points) in float c[]; + +void main() +{ +} diff --git a/tests/spec/glsl-1.50/compiler/incorrect-out-layout-qualifiers-with-variable-declarations.geom b/tests/spec/glsl-1.50/compiler/incorrect-out-layout-qualifiers-with-variable-declarations.geom new file mode 100644 index 0000000..161de1c --- /dev/null +++ b/tests/spec/glsl-1.50/compiler/incorrect-out-layout-qualifiers-with-variable-declarations.geom @@ -0,0 +1,19 @@ +// [config] +// expect_result: fail +// glsl_version: 1.50 +// check_link: true +// [end config] +// +// Tests that output layout qualifiers cannot be used on a variable declaration. +// +// GLSLangSpec 1.50, section 4.3.8.2 (Output Layout Qualifiers): +// "Geometry shaders can have output layout qualifiers only on the interface +// qualifier out, not on an output block or variable declaration." + +#version 150 + +layout(points) out float c; + +void main() +{ +} -- 1.8.3.1 _______________________________________________ Piglit mailing list <a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a> </blockquote></div> </div></div>