<div dir="ltr">On 8 October 2013 13:55, Vinson Lee <span dir="ltr"><<a href="mailto:vlee@freedesktop.org" target="_blank">vlee@freedesktop.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class=""><div class="h5">On Tue, Oct 8, 2013 at 12:47 PM, Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>> wrote:<br>
> On 8 October 2013 11:56, Vinson Lee <<a href="mailto:vlee@freedesktop.org">vlee@freedesktop.org</a>> wrote:<br>
>><br>
>> Signed-off-by: Vinson Lee <<a href="mailto:vlee@freedesktop.org">vlee@freedesktop.org</a>><br>
>> ---<br>
>>  .../geometry/geometry-end-primitive-optional-with-points-out.c          |<br>
>> 2 ++<br>
>>  1 file changed, 2 insertions(+)<br>
>><br>
>> diff --git<br>
>> a/tests/spec/glsl-1.50/execution/geometry/geometry-end-primitive-optional-with-points-out.c<br>
>> b/tests/spec/glsl-1.50/execution/geometry/geometry-end-primitive-optional-with-points-out.c<br>
>> index d6c4b44..13fb7eb 100644<br>
>> ---<br>
>> a/tests/spec/glsl-1.50/execution/geometry/geometry-end-primitive-optional-with-points-out.c<br>
>> +++<br>
>> b/tests/spec/glsl-1.50/execution/geometry/geometry-end-primitive-optional-with-points-out.c<br>
>> @@ -93,6 +93,8 @@ piglit_init(int argc, char **argv)<br>
>>         GLuint vs = 0, gs = 0, fs = 0;<br>
>>         GLuint vertIndex;<br>
>><br>
>> +       piglit_require_GLSL_version(150);<br>
>> +<br>
>>         prog = glCreateProgram();<br>
>>         vs = piglit_compile_shader_text(GL_VERTEX_SHADER, vstext);<br>
>>         gs = piglit_compile_shader_text(GL_GEOMETRY_SHADER, gstext);<br>
>> --<br>
>> 1.8.1.2<br>
><br>
><br>
> The test already specifies<br>
><br>
>     config.supports_gl_compat_version = 32;<br>
>     config.supports_gl_core_version = 32;<br>
><br>
> and GL 3.2 requires GLSL 1.50, so it seems to me that this shouldn't be<br>
> necessary.<br>
<br>
<br>
</div></div>I'm seeing this test fail on swrast instead of reporting a skip.<br>
</blockquote></div><br></div><div class="gmail_extra">That's strange.  When I run this test with LIBGL_ALWAYS_SOFTWARE=1 I get:<br><br>piglit: info: Failed to create GL 3.2 core context<br>piglit: info: Falling back to GL 3.2 compatibility context<br>
piglit: info: Requested a GL 3.2 compatibility context, but actual context version is 2.1<br>piglit: info: Failed to create GL 3.2 compatibility context<br>piglit: info: Failed to create any GL context<br>PIGLIT: {'result': 'skip' }<br>
</div></div>