<div dir="ltr">On 21 October 2013 17:36, Dylan Baker <span dir="ltr"><<a href="mailto:baker.dylan.c@gmail.com" target="_blank">baker.dylan.c@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The list comprehension can be further refined to be fixed, but the<br>
resulting code is much more difficult to read than the try/except<br>
statement.<br>
<br>
This reverts commit aaae592490a6459aba52bc306b819a7fcbaa3008.<br>
This reverts commit 450935b06f8508d3f4177fe7336e3bdee3973a9e.<br>
<br>
CC: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br>
Signed-off-by: Dylan Baker <<a href="mailto:baker.dylan.c@gmail.com">baker.dylan.c@gmail.com</a>><br></blockquote><div><br></div><div>Thanks, Dylan!<br><br></div><div>Tested-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br>
</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
framework/summary.py | 8 ++++++--<br>
1 file changed, 6 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/framework/summary.py b/framework/summary.py<br>
index 3e5c24e..6084621 100644<br>
--- a/framework/summary.py<br>
+++ b/framework/summary.py<br>
@@ -361,8 +361,12 @@ class Summary:<br>
# Create the lists of statuses like problems, regressions, fixes,<br>
# changes and skips<br>
for test in self.tests['all']:<br>
- status = [i.tests.get('test', {}).get('result', so.NotRun())<br>
- for i in self.results]<br>
+ status = []<br>
+ for each in self.results:<br>
+ try:<br>
+ status.append(each.tests[test]['result'])<br>
+ except KeyError:<br>
+ status.append(so.NotRun())<br>
<br>
# Problems include: warn, dmesg-warn, fail, dmesg-fail, and crash.<br>
# Skip does not go on this page, it has the 'skipped' page<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.8.1.5<br>
<br>
</font></span></blockquote></div><br></div></div>