<div dir="ltr">On 25 October 2013 16:49, Anuj Phogat <span dir="ltr"><<a href="mailto:anuj.phogat@gmail.com" target="_blank">anuj.phogat@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Tests gl_SamplePosition,<br>
gl_SampleID,<br>
gl_NumSamples,<br>
gl_SampleMask[]<br>
<br>
Signed-off-by: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>><br></blockquote><div><br></div><div>Personally, I don't think these tests are necessary. The previous patches adequately exercise compilation of these new built-ins.<br>
<br></div><div>I don't feel terribly strongly, though. If you want to keep them, you can consider this patch:<br><br>Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br>
</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
tests/all.tests | 4 ++++<br>
tests/spec/arb_sample_shading/compiler/gl_NumSamples.frag | 12 ++++++++++++<br>
tests/spec/arb_sample_shading/compiler/gl_SampleID.frag | 12 ++++++++++++<br>
tests/spec/arb_sample_shading/compiler/gl_SampleMask.frag | 13 +++++++++++++<br>
.../spec/arb_sample_shading/compiler/gl_SamplePosition.frag | 12 ++++++++++++<br>
5 files changed, 53 insertions(+)<br>
create mode 100644 tests/spec/arb_sample_shading/compiler/gl_NumSamples.frag<br>
create mode 100644 tests/spec/arb_sample_shading/compiler/gl_SampleID.frag<br>
create mode 100644 tests/spec/arb_sample_shading/compiler/gl_SampleMask.frag<br>
create mode 100644 tests/spec/arb_sample_shading/compiler/gl_SamplePosition.frag<br>
<br>
diff --git a/tests/all.tests b/tests/all.tests<br>
index 9df5a94..717d41f 100644<br>
--- a/tests/all.tests<br>
+++ b/tests/all.tests<br>
@@ -1357,6 +1357,10 @@ for num_samples in TEST_SAMPLE_COUNTS:<br>
executable = 'arb_sample_shading-{0} -auto'.format(test_name)<br>
arb_sample_shading[test_name] = PlainExecTest(executable)<br>
<br>
+import_glsl_parser_tests(spec['ARB_sample_shading'],<br>
+ os.path.join(testsDir, 'spec', 'arb_sample_shading'),<br>
+ ['compiler'])<br>
+<br>
# Group ARB_debug_output<br>
arb_debug_output = Group()<br>
spec['ARB_debug_output'] = arb_debug_output<br>
diff --git a/tests/spec/arb_sample_shading/compiler/gl_NumSamples.frag b/tests/spec/arb_sample_shading/compiler/gl_NumSamples.frag<br>
new file mode 100644<br>
index 0000000..d99e8b8<br>
--- /dev/null<br>
+++ b/tests/spec/arb_sample_shading/compiler/gl_NumSamples.frag<br>
@@ -0,0 +1,12 @@<br>
+// [config]<br>
+// expect_result: pass<br>
+// glsl_version: 1.30<br>
+// require_extensions: GL_ARB_sample_shading<br>
+// [end config]<br>
+#version 130<br>
+#extension GL_ARB_sample_shading : enable<br>
+<br>
+int func()<br>
+{<br>
+ return gl_NumSamples;<br>
+}<br>
diff --git a/tests/spec/arb_sample_shading/compiler/gl_SampleID.frag b/tests/spec/arb_sample_shading/compiler/gl_SampleID.frag<br>
new file mode 100644<br>
index 0000000..0d202be<br>
--- /dev/null<br>
+++ b/tests/spec/arb_sample_shading/compiler/gl_SampleID.frag<br>
@@ -0,0 +1,12 @@<br>
+// [config]<br>
+// expect_result: pass<br>
+// glsl_version: 1.30<br>
+// require_extensions: GL_ARB_sample_shading<br>
+// [end config]<br>
+#version 130<br>
+#extension GL_ARB_sample_shading : enable<br>
+<br>
+int func()<br>
+{<br>
+ return gl_SampleID;<br>
+}<br>
diff --git a/tests/spec/arb_sample_shading/compiler/gl_SampleMask.frag b/tests/spec/arb_sample_shading/compiler/gl_SampleMask.frag<br>
new file mode 100644<br>
index 0000000..1e659bc<br>
--- /dev/null<br>
+++ b/tests/spec/arb_sample_shading/compiler/gl_SampleMask.frag<br>
@@ -0,0 +1,13 @@<br>
+// [config]<br>
+// expect_result: pass<br>
+// glsl_version: 1.30<br>
+// require_extensions: GL_ARB_sample_shading<br>
+// [end config]<br>
+#version 130<br>
+#extension GL_ARB_sample_shading : enable<br>
+<br>
+int func()<br>
+{<br>
+ gl_SampleMask[0] = 0xff;<br>
+ return 0;<br>
+}<br>
diff --git a/tests/spec/arb_sample_shading/compiler/gl_SamplePosition.frag b/tests/spec/arb_sample_shading/compiler/gl_SamplePosition.frag<br>
new file mode 100644<br>
index 0000000..be42d90<br>
--- /dev/null<br>
+++ b/tests/spec/arb_sample_shading/compiler/gl_SamplePosition.frag<br>
@@ -0,0 +1,12 @@<br>
+// [config]<br>
+// expect_result: pass<br>
+// glsl_version: 1.30<br>
+// require_extensions: GL_ARB_sample_shading<br>
+// [end config]<br>
+#version 130<br>
+#extension GL_ARB_sample_shading : enable<br>
+<br>
+vec2 func()<br>
+{<br>
+ return gl_SamplePosition;<br>
+}<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.8.1.4<br>
<br>
_______________________________________________<br>
Piglit mailing list<br>
<a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a><br>
</font></span></blockquote></div><br></div></div>