<div dir="ltr"><div><div><div><div><div><div>I had to add a few more patches to the commit list due to bugs I found.<br><br><br>* git: add install_manifest.txt to gitignore<br><br></div>This is simple enough... When you type "Make Package" you will wind up having a file called install_manifest.txt appear.<br>
<br><br>* cmake: Install templates on make package.<br></div>Another simple enough bug... The Installation results did not include the mako template files for html.<br><br><br></div>Also, I spotted two things th at really need to be paid attention to...<br>
<br>1) pkg-config usage in cmake... The current system works well enough on linux, but when you go to windows or other operating systems this can rapidly cause problems because not all platforms have this by default. The best example of this is what is going on with Linux. The FindPkgConfig module has a nice little FOUND flag called PKG_CONFIG_FOUND. We should use this before making any calls to the to the commands pkg_check_modules and pkg_search_module.<br>
<br></div>2) Some tests have insanely long file names and test names. 70+ Character file names and test names may be nice on most platforms but it generates problems for windows/linux... I suggest trying to limit the file name to at most 32 characters. This is because of how piglit works using the cmake script work. Two good examples are as follows.<br>
<br>* same-attachment-glFramebufferTexture2D-GL_DEPTH_STENCIL_ATTACHMENT<br><br></div>Results in a file called:<br>target_api/gl/tests/spec/arb_framebuffer_object/CMakeFiles/same-attachment-glFramebufferTexture2D-GL_DEPTH_STENCIL_ATTACHMENT.dir/same-attachment-glFramebufferTexture2D-GL_DEPTH_STENCIL_ATTACHMENT.c.o<br>
<br></div>This is 200 characters on it's own... this throws a lot of errors with the generators on windows.<br><div><div><div><br><br>* same-attachment-glFramebufferRenderbuffer-GL_DEPTH_STENCIL_ATTACHMENT<br><br></div>
<div>Same problem as the other test. This results in a 206 character long path...<br>target_api/gl/tests/spec/arb_framebuffer_object/CMakeFiles/same-attachment-glFramebufferRenderbuffer-GL_DEPTH_STENCIL_ATTACHMENT.dir/same-attachment-glFramebufferRenderbuffer-GL_DEPTH_STENCIL_ATTACHMENT.c.o<br>
<br><br></div><div>I believe there may be more but this should be a good start.<br><br></div><div>3) This may not sound like much, but html generation on windows is broken. This is due to Illegal Characters in File/Folder names. There is a couple of articles over this and it is not exactly hard to implement. Please refer to the following Wikipedia article ( <a href="http://en.wikipedia.org/wiki/Filename">http://en.wikipedia.org/wiki/Filename</a> ) and pay attention to the filename limitations.<br>
</div></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Nov 3, 2013 at 9:54 AM, Ken Phillis Jr <span dir="ltr"><<a href="mailto:kphillisjr@gmail.com" target="_blank">kphillisjr@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Since some patches landed that did not allow my patch set to apply Cleanly, I went ahead and updated my local tree and placed the patches on github. The patches are in my glfw-sig-patch branch on github. The commit history is located at...<br>
<br><a href="https://github.com/kphillisjr/piglit/commits/glfw-sig-patch" target="_blank">https://github.com/kphillisjr/piglit/commits/glfw-sig-patch</a><br><br></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra">
<br><br><div class="gmail_quote">On Fri, Nov 1, 2013 at 2:31 PM, Ken Phillis Jr <span dir="ltr"><<a href="mailto:kphillisjr@gmail.com" target="_blank">kphillisjr@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>I added two more changes to this patch series. For patches the following patches<br>* piglit-framework-gl: Add piglit signal handler.<br>
* util: Implement signal handler on windows.<br><br></div>The change is to have all output except for...<br>
PIGLIT: {'result': 'crash' }<br><br></div>changed to print to stderr instead of stdout. This will make it to where the summary<br>information to html will have the callstack on top.<div><br><div>
<div><div><br><div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Oct 31, 2013 at 12:27 PM, Ken Phillis Jr <span dir="ltr"><<a href="mailto:kphillisjr@gmail.com" target="_blank">kphillisjr@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra">I have applied the suggestions that Dylan Baker suggested to the following patches.<br>
<br>* framework/summary.py: add crashed page.<br>* cmake: use PythonInterp package and update version.<br>
<br></div><div class="gmail_extra">I will be submitting the updated patch set in a few days after I get more feedback on the<br>other patches.<br></div></div></blockquote></div></div></div></div></div></div></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>