<html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 04/09/2014 12:27 AM, Ken Phillis Jr wrote: </div> <blockquote cite="mid:CACiKS=TN6YBA6g0L1F+wRNsxPKv_EFrcFfuP63CP2vxAmmUfqQ@mail.gmail.com" type="cite"> <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1"> The patch looks good, but I would suggest improving commit message... for example... Title (line 1): GLSL ES fix default precision qualifiers The OpenGl ES specification for (whatever the version is being checked against) section 4.5.4 ("Default precision qualifier") : The fragment language has no default precision qualifier for floating point types. Hence for float, floating point vector and matrix variable declarations, either the declaration must include a precision qualifier or the default float precision must have been previously declared. </blockquote> I'm not sure I understand what this patch fixes. I thought the "precision mediump float;" declaration that is present in all those tests is enough. -- Petri Latvala </body> </html>