<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=gb2312">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:宋体;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:"\@宋体";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman","serif";
color:black;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";
color:black;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";
color:black;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body bgcolor="white" lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Yes. You are right, either “</span>precision mediump float;" or “highp” will be OK.<o:p></o:p></p>
<p class="MsoNormal">But you can’t leave it as unknown precision qualifer.<span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext"> Petri Latvala [mailto:petri.latvala@intel.com]
<br>
<b>Sent:</b> 2014</span><span lang="ZH-CN" style="font-size:10.0pt;font-family:宋体;color:windowtext">年</span><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">4</span><span lang="ZH-CN" style="font-size:10.0pt;font-family:宋体;color:windowtext">月</span><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">9</span><span lang="ZH-CN" style="font-size:10.0pt;font-family:宋体;color:windowtext">日</span><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">
15:49<br>
<b>To:</b> piglit@lists.freedesktop.org<br>
<b>Cc:</b> Ken Phillis Jr; Jin Zhou; Guo, Johney<br>
<b>Subject:</b> Re: [Piglit] [PATCH] ES spec section 4.5.4 ("Default precision qualifier") : The fragment language has no default precision qualifier for floating point types. Hence for float, floating point vector and matrix variable declarations, either the
declarat...<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On 04/09/2014 12:27 AM, Ken Phillis Jr wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p>The patch looks good, but I would suggest improving commit message... for example...<o:p></o:p></p>
<p>Title (line 1): GLSL ES fix default precision qualifiers<o:p></o:p></p>
<p>The OpenGl ES specification for (whatever the version is being checked against) section 4.5.4 ("Default precision qualifier") : The fragment language has no default precision qualifier for floating point types. Hence for float, floating point vector and
matrix variable declarations, either the declaration must include a precision qualifier or the default float precision must have been previously declared.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</blockquote>
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
I'm not sure I understand what this patch fixes. I thought the "precision mediump float;" declaration that is present in all those tests is enough.<br>
<br>
<br>
-- <br>
Petri Latvala<o:p></o:p></p>
</div>
</body>
</html>