<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/REC-html40/strict.dtd"> <html><head><meta name="qrichtext" content="1" /><style type="text/css"> p, li { white-space: pre-wrap; } </style></head><body style=" font-family:'DejaVu Sans Mono'; font-size:9pt; font-weight:400; font-style:normal;"> On Monday, May 19, 2014 18:04:29 Ilia Mirkin wrote: > On Mon, May 19, 2014 at 6:00 PM, Dylan Baker <baker.dylan.c@gmail.com> wrote: > > On Monday, May 19, 2014 17:54:28 Ilia Mirkin wrote: > >> On Mon, May 19, 2014 at 5:43 PM, Dylan Baker <baker.dylan.c@gmail.com> > >> > >> wrote: > >> > Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com> > >> > > >> > --- > >> > > >> > generated_tests/gen_const_builtin_equal_tests.py | 77 > >> > +++++++++--------------- > >> > > >> > 1 file changed, 29 insertions(+), 48 deletions(-) > >> > > >> > > >> > > >> > diff --git a/generated_tests/gen_const_builtin_equal_tests.py > >> > b/generated_tests/gen_const_builtin_equal_tests.py > >> > > >> > index 79b5a1d..0e7543f 100644 > >> > > >> > --- a/generated_tests/gen_const_builtin_equal_tests.py > >> > > >> > +++ b/generated_tests/gen_const_builtin_equal_tests.py > >> > > >> > @@ -48,53 +48,34 @@ TEMPLATE = > >> > mako.template.Template(textwrap.dedent(""" > >> > > >> > draw rect -1 -1 2 2 > >> > > >> > probe all rgb 0.0 1.0 0.0""")) > >> > > >> > > >> > > >> > -test_vectors = [ > >> > > >> > - [ > >> > > >> > - "vec2(3.0, 3.14)", > >> > > >> > - "vec2(-6.0, 7.88)", > >> > > >> > - "bvec2(false, false)" > >> > > >> > - ], > >> > > >> > - [ > >> > >> I really like the visual separation between the different test cases > >> > >> here... what is it that pylint is complaining about? Just test_vectors > >> > >> vs TEST_VECTORS? > >> > >> > >> > >> Perhaps a format more like > >> > >> > >> > >> + ["vec2(3.0, 3.14)", > >> > >> + "vec2(-6.0, 7.88)", > >> > >> + "bvec2(false, false)" > >> > >> ], > >> > >> + ["vec3(13.4, -0.9, 12.55)", > >> > >> + "vec3(13.4, 12.0, -55.3)", > >> > >> + "bvec3(true, false, false)" > >> > >> ], > >> > >> > >> > >> Would keep pylint happy while preserving the visual separation between > >> > >> the test cases? > >> > >> > - "vec3(13.4, -0.9, 12.55)", > >> > > >> > - "vec3(13.4, 12.0, -55.3)", > >> > > >> > - "bvec3(true, false, false)" > > > > it complains about bad hanging indent, it wants the '],' to be dedented > > > > which results in: > > > > ], > > > > [ > > > > ... > > > > ], > > > > [ > > > > > > > > And that just adds a lot of white space. could we go to: > > > > [ > > > > ...], > > > > [ > > > > ...], > > Is the diff between that and my suggestion whether the first line is > empty vs last line? I don't really care. Although a minor prefer for > "my" way, since that way adding elements to the array doesn't require > changing any lines if items are added to the end. (I also like > trailing commas for that reason.) > > Or perhaps I misunderstood, can you give an example with the actual > values filled in for like 2 elements of the array? Actually, I think your suggestion is fine. My client did something weird to it but looking at it in webmail it looks fine. I'll send out a v2 </body></html>