<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/REC-html40/strict.dtd"> <html><head><meta name="qrichtext" content="1" /><style type="text/css"> p, li { white-space: pre-wrap; } </style></head><body style=" font-family:'DejaVu Sans Mono'; font-size:9pt; font-weight:400; font-style:normal;"> On Tuesday, May 27, 2014 12:40:15 Sun, Yi wrote: > Hi Dylan, > > This patch introduced an error while compiling. The error information is like following. > > [100%] Generating non-lvalue_tests.list > [100%] Generating texture_query_lod_tests.list > [100%] Generating texture_lod_tests.list > Traceback (most recent call last): > File "/home/OpenCL/piglit/generated_tests/gen_texture_lod_tests.py", line 180, in <module> > main() > File "/home/OpenCL/piglit/generated_tests/gen_texture_lod_tests.py", line 159, in main > **params.__dict__)) > AttributeError: 'Parameters' object has no attribute '__dict__' > make[2]: *** [generated_tests/texture_lod_tests.list] Error 1 > make[1]: *** [generated_tests/CMakeFiles/gen-tests.dir/all] Error 2 > make: *** [all] Error 2 > > Thanks > --Sun, Yi > > > -----Original Message----- > > From: Piglit [mailto:piglit-bounces@lists.freedesktop.org] On Behalf Of Dylan > > Baker > > Sent: Thursday, May 22, 2014 5:10 AM > > To: piglit@lists.freedesktop.org > > Subject: [Piglit] [PATCH 7/7] gen_texture_lod_tests.py: Give the tests insightful > > names > > > > This is a trivial change that renames generated tests from 01, 02, 03... > > to names that express what is actually being tested. This information was > > already available to the function generating the tests, it just wasn't used. > > > > Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com> > > --- > > generated_tests/gen_texture_lod_tests.py | 18 ++++++++++-------- > > 1 file changed, 10 insertions(+), 8 deletions(-) > > > > diff --git a/generated_tests/gen_texture_lod_tests.py > > b/generated_tests/gen_texture_lod_tests.py > > index 2e8a40b..f6bc086 100644 > > --- a/generated_tests/gen_texture_lod_tests.py > > +++ b/generated_tests/gen_texture_lod_tests.py > > @@ -153,23 +153,25 @@ def main(): > > except OSError: > > pass > > > > - for count, params in enumerate(LOD_TESTS, start=1): > > + for params in LOD_TESTS: > > name = ("spec/arb_shader_texture_lod/compiler/" > > - "tex_lod-{0:02d}.frag".format(count)) > > + "tex_lod-{mode}-{dimensions}-{coord}.frag".format( > > + **params.__dict__)) > > print(name) > > gen_frag_lod_test(params, name) > > > > - for count, params in enumerate(GRAD_TESTS, start=1): > > + for params in GRAD_TESTS: > > + # Generate fragment shader test > > name = ("spec/arb_shader_texture_lod/compiler/" > > - "tex_grad-{0:02d}.frag".format(count)) > > + "tex_grad-{mode}-{dimensions}-{coord}.frag".format( > > + **params.__dict__)) > > print(name) > > gen_frag_grad_test(params, name) > > > > - # Start the count at len(GRAD_TESTS) + 1 so that the frag and vertex > > tests > > - # are sequentially numbered. > > - for count, params in enumerate(GRAD_TESTS, start=len(GRAD_TESTS) + > > 1): > > + # Generate vertex shader test > > name = ("spec/arb_shader_texture_lod/compiler/" > > - "tex_grad-{0:02d}.vert".format(count)) > > + "tex_grad-{mode}-{dimensions}-{coord}.vert".format( > > + **params.__dict__)) > > print(name) > > gen_vert_grad_test(params, name) > > > > -- > > 2.0.0.rc2 > > > > _______________________________________________ > > Piglit mailing list > > Piglit@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/piglit Yes, there is a ptach on the list for this problem. I'm planning to push it shortly.</body></html>