<p dir="ltr">I think this is a good idea and the patch looks good. Although I would suggest some calculations to see how much was skipped by reaching the failure threshold. </p>
<div class="gmail_quote">On Jul 16, 2014 4:35 PM, "Brian Paul" <<a href="mailto:brianp@vmware.com">brianp@vmware.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
rather than continuing. As it was, if something is majorly broken in<br>
the driver, this test could report nearly 60,000 failure messages.<br>
The results.json file is pretty huge in this case.<br>
---<br>
tests/texturing/tex-miplevel-selection.c | 9 +++++++++<br>
1 file changed, 9 insertions(+)<br>
<br>
diff --git a/tests/texturing/tex-miplevel-selection.c b/tests/texturing/tex-miplevel-selection.c<br>
index 0f03c6e..11e4292 100644<br>
--- a/tests/texturing/tex-miplevel-selection.c<br>
+++ b/tests/texturing/tex-miplevel-selection.c<br>
@@ -1456,6 +1456,10 @@ piglit_display(void)<br>
maxlevel, minlod, maxlod,<br>
bias, mipfilter)) {<br>
failed++;<br>
+ if (failed > 100) {<br>
+ printf("Stopping after 100 failures\n");<br>
+ goto end;<br>
+ }<br>
}<br>
}<br>
total++;<br>
@@ -1492,12 +1496,17 @@ piglit_display(void)<br>
baselevel, maxlevel, minlod,<br>
maxlod, bias, mipfilter)) {<br>
failed++;<br>
+ if (failed > 100) {<br>
+ printf("Stopping after 100 failures\n");<br>
+ goto end;<br>
+ }<br>
}<br>
total++;<br>
}<br>
free(pix);<br>
}<br>
<br>
+end:<br>
assert(glGetError() == 0);<br>
printf("Summary: %i/%i passed\n", total-failed, total);<br>
<br>
--<br>
1.7.10.4<br>
<br>
_______________________________________________<br>
Piglit mailing list<br>
<a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a><br>
</blockquote></div>