<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jul 29, 2014 at 9:46 AM, Jon TURNEY <span dir="ltr"><<a href="mailto:jon.turney@dronecode.org.uk" target="_blank">jon.turney@dronecode.org.uk</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 22/07/2014 23:54, Anuj Phogat wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">
On Mon, Jul 21, 2014 at 11:21 AM, Jon TURNEY wrote:<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">
Fix a typo so that GL_PROXY_TEXTURE_RECTANGLE test actually tests that.<br></div><div class="">
---<br>
  tests/texturing/max-texture-<u></u>size.c | 4 ++--<br>
  1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/tests/texturing/max-texture-<u></u>size.c b/tests/texturing/max-texture-<u></u>size.c<br>
index 8afa9ef..e9f5c6b 100644<br>
--- a/tests/texturing/max-texture-<u></u>size.c<br>
+++ b/tests/texturing/max-texture-<u></u>size.c<br>
@@ -195,8 +195,8 @@ test_proxy_texture_size(GLenum target, GLenum internalformat)<br>
                 break;<br>
<br>
         case GL_TEXTURE_RECTANGLE:<br>
-               glTexImage2D(target, 0, internalformat, maxSide,<br>
-                            maxSide, 0, GL_RGBA, GL_FLOAT, NULL);<br>
+               glTexImage2D(GL_PROXY_TEXTURE_<u></u>RECTANGLE, 0, internalformat,<br>
+                            maxSide, maxSide, 0, GL_RGBA, GL_FLOAT, NULL);<br>
                 break;<br>
</div></blockquote><div class="">
It will be nice to define a proxyTarget variable here and get its value using<br>
getProxyTarget(target). Then you can combine the cases for TEXTURE_2D,<br>
TEXTURE_RECTANGLE and TEXTURE_CUBE_MAP together.<br>
Whether you decide to use my suggestion or not, patch is:<br></div>
Reviewed-by: Anuj Phogat <<a href="mailto:anuj.phogat-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" target="_blank">anuj.phogat-<u></u>Re5JQEeQqe8AvxtiuMwx3w@public.<u></u>gmane.org</a>><br>
</blockquote>
<br>
Would you mind committing this patch for me?  I don't think I have commit access to piglit.<div class="HOEnZb"><div class="h5"><br></div></div></blockquote><div>Pushed. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<div class="HOEnZb"><div class="h5">
<br>
______________________________<u></u>_________________<br>
Piglit mailing list<br>
<a href="mailto:Piglit@lists.freedesktop.org" target="_blank">Piglit@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/<u></u>mailman/listinfo/piglit</a><br>
</div></div></blockquote></div><br></div></div>