<div dir="ltr">I landed this patch to fix the break. It is building on all ChromeOS devices now:<div><a href="https://chromium-review.googlesource.com/#/c/212543/3/media-libs/piglit/files/0001-piglit-Fix-tegra-build-break.patch">https://chromium-review.googlesource.com/#/c/212543/3/media-libs/piglit/files/0001-piglit-Fix-tegra-build-break.patch</a><br>
</div><div><br></div><div>Ilja.</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Aug 18, 2014 at 4:05 PM, Chad Versace <span dir="ltr"><<a href="mailto:chad.versace@linux.intel.com" target="_blank">chad.versace@linux.intel.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 08/13/2014 07:13 PM, Daniel Kurtz wrote:<br>
<div><div class="h5">><br>
><br>
><br>
> On Thu, Aug 14, 2014 at 6:41 AM, Chad Versace <<a href="mailto:chad.versace@linux.intel.com">chad.versace@linux.intel.com</a> <mailto:<a href="mailto:chad.versace@linux.intel.com">chad.versace@linux.intel.com</a>>> wrote:<br>

><br>
>     On 08/07/2014 04:09 AM, Daniel Kurtz wrote:<br>
>     > These tests all require EGL_KHR_reusable_sync.<br>
><br>
>     No they don't, at least according to the spec. Have you found a buggy driver?<br>
>     Or... maybe I wrote the test totally wrong... I hope not.<br>
><br>
>     EGL_KHR_resuable_sync defines the sync type EGL_SYNC_REUSABLE_KHR, which this test does<br>
>     not use according to grep, but does not define EGL_SYNC_FENCE_KHR. EGL_KHR_fence_sync<br>
>     defines the sync type EGL_SYNC_FENCE_KHR, which this test<br>
>     does use.<br>
><br>
>     What driver is causing you problems? Could you add a workaround to this test<br>
>     for that driver?<br>
><br>
><br>
> <a href="http://www.khronos.org/registry/egl/extensions/KHR/EGL_KHR_reusable_sync.txt" target="_blank">http://www.khronos.org/registry/egl/extensions/KHR/EGL_KHR_reusable_sync.txt</a><br>
> EGL_KHR_reusable_sync defines some of the functions this test actually uses....<br>
> AFAICT, without this extension, the following procedures and functions don't exist:<br>
><br>
><br>
>     EGLSyncKHR eglCreateSyncKHR(<br>
>                         EGLDisplay dpy,<br>
>                         EGLenum type,<br>
>                         const EGLint *attrib_list);<br>
><br>
>     EGLBoolean eglDestroySyncKHR(<br>
>                         EGLDisplay dpy,<br>
>                         EGLSyncKHR sync);<br>
><br>
>     EGLint eglClientWaitSyncKHR(<br>
>                         EGLDisplay dpy,<br>
>                         EGLSyncKHR sync,<br>
>                         EGLint flags,<br>
>                         EGLTimeKHR timeout);<br>
><br>
>     EGLBoolean eglSignalSyncKHR(<br>
>                         EGLDisplay dpy,<br>
>                         EGLSyncKHR sync,<br>
>                         EGLenum mode);<br>
><br>
>     EGLBoolean eglGetSyncAttribKHR(<br>
>                         EGLDisplay dpy,<br>
>                         EGLSyncKHR sync,<br>
>                         EGLint attribute,<br>
>                         EGLint *value);<br>
<br>
</div></div>The test uses 4 of the above 5 functions, listed below. EGL_KHR_fence_sync<br>
also provides these 4 functions (<a href="http://www.khronos.org/registry/egl/extensions/KHR/EGL_KHR_fence_sync.txt" target="_blank">http://www.khronos.org/registry/egl/extensions/KHR/EGL_KHR_fence_sync.txt</a>).<br>
  eglCreateSyncKHR<br>
  eglDestroySyncKHR<br>
  eglClientWaitSyncKHR<br>
  eglGetSyncAttribKHR<br>
<br>
Function eglSignalSyncKHR, EGL_KHR_resuable_sync provides it but EGL_KHR_fence_sync<br>
does not. The test does not use this function, because it is testing EGL_KHR_fence_sync,<br>
not EGL_KHR_reusable_sync.<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
_______________________________________________<br>
Piglit mailing list<br>
<a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a><br>
</div></div></blockquote></div><br></div>