<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 09/03/2014 01:51 AM, Ken Phillis Jr
wrote:<br>
</div>
<blockquote
cite="mid:CACiKS=SkmOxsbK2e2nta9AJz-8vdz9r+XmeONRevBnn0sO9txg@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div>
<div>I agree, but I would suggest further changes. This
extension has a lot of variations...<br>
<br>
Core Variation 1: OpenGL 3.3 - Simplifies things, but is not
a good benchmark.<br>
</div>
<br>
Core Variation 2: OpenGL 1.0 with three extensions
ARB_explicit_attrib_location, GL_ARB_vertex_shader,
ARB_shader_objects<br>
</div>
<div>
<div>
<div><br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
I don't see how this would make sense, we are testing specific parts
of GL_ARB_explicit_uniform_location implementation here, not
anything else. If one wants to test interaction or behavior with
other extensions then it requires a specific test for that purpose.
I dislike already the fact that I need to require/enable
GL_ARB_explicit_attrib_location which is not used at all by these
tests.<br>
<br>
<blockquote
cite="mid:CACiKS=SkmOxsbK2e2nta9AJz-8vdz9r+XmeONRevBnn0sO9txg@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div>
<div>Side Variation 1: interaction with
ARB_shader_subroutine<br>
<br>
Side Variation 2: ARB_explicit_attrib_location has various
interactions with the following extensions...
GL_ARB_blend_func_extended,
GL_ARB_separate_shader_objects, GL_ARB_gpu_shader_fp64,
OpenGL 4.0, and OpenGL 4.1.<br>
[1] Specification for ARB_explicit_uniform_location<br>
<a moz-do-not-send="true"
href="https://www.opengl.org/registry/specs/ARB/explicit_uniform_location.txt">https://www.opengl.org/registry/specs/ARB/explicit_uniform_location.txt</a>
<br>
<br>
</div>
<div>[2]<br>
Specification for ARB_explicit_attrib_location<br>
<a moz-do-not-send="true"
href="https://www.opengl.org/registry/specs/ARB/explicit_attrib_location.txt"
target="_blank">https://www.opengl.org/registry/specs/ARB/explicit_attrib_location.txt</a><br>
</div>
</div>
</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Tue, Sep 2, 2014 at 5:07 PM, Matt
Turner <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:mattst88@gmail.com" target="_blank">mattst88@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb">
<div class="h5">On Tue, Sep 2, 2014 at 1:32 AM, Tapani
Pälli <<a moz-do-not-send="true"
href="mailto:tapani.palli@intel.com">tapani.palli@intel.com</a>>
wrote:<br>
> Signed-off-by: Tapani Pälli <<a
moz-do-not-send="true"
href="mailto:tapani.palli@intel.com">tapani.palli@intel.com</a>><br>
> ---<br>
>
tests/spec/arb_explicit_uniform_location/array-elements.c
| 6 ++++--<br>
>
.../spec/arb_explicit_uniform_location/compiler/layout-01.frag
| 7 ++++---<br>
>
.../spec/arb_explicit_uniform_location/compiler/layout-01.vert
| 7 ++++---<br>
>
tests/spec/arb_explicit_uniform_location/inactive-uniform.c
| 6 ++++--<br>
> .../linker/overlap-array-loc-stages.shader_test
| 10 ++++++----<br>
> .../linker/overlap-array-loc.shader_test
| 7 ++++---<br>
>
.../linker/overlap-location-across-stages.shader_test
| 10 ++++++----<br>
>
.../linker/set-explicit-location-once-decl-twice.shader_test
| 10 ++++++----<br>
>
.../linker/set-explicit-location-twice.shader_test
| 9 ++++++---<br>
> .../linker/set-location-to-sampler.shader_test
| 7 ++++---<br>
>
.../linker/set-same-explicit-location-twice.shader_test
| 10 ++++++----<br>
>
.../linker/unused-uniform-reserve-location.shader_test
| 10 ++++++----<br>
>
tests/spec/arb_explicit_uniform_location/loc-boundaries.c
| 6 ++++--<br>
>
.../arb_explicit_uniform_location/preprocessor/define.frag
| 7 ++++---<br>
>
.../arb_explicit_uniform_location/preprocessor/define.vert
| 7 ++++---<br>
> 15 files changed, 72 insertions(+), 47
deletions(-)<br>
><br>
> diff --git
a/tests/spec/arb_explicit_uniform_location/array-elements.c
b/tests/spec/arb_explicit_uniform_location/array-elements.c<br>
> index 72cb784..1fa91d4 100644<br>
> ---
a/tests/spec/arb_explicit_uniform_location/array-elements.c<br>
> +++
b/tests/spec/arb_explicit_uniform_location/array-elements.c<br>
> @@ -34,7 +34,7 @@<br>
><br>
> PIGLIT_GL_TEST_CONFIG_BEGIN<br>
><br>
> - config.supports_gl_core_version = 33;<br>
> + config.supports_gl_compat_version = 20;<br>
> config.window_visual =
PIGLIT_GL_VISUAL_RGB;<br>
><br>
> PIGLIT_GL_TEST_CONFIG_END<br>
> @@ -52,7 +52,8 @@ static const char vs_text[] =<br>
> "}";<br>
><br>
> static const char fs_text[] =<br>
> - "#version 330\n"<br>
> + "#version 130\n"<br>
<br>
</div>
</div>
You're asking for only a GL 2.0 version, but a version 130
shader.<br>
Shouldn't you be asking for a GL 3.0 minimum version?<br>
<div class="HOEnZb">
<div class="h5">_______________________________________________<br>
Piglit mailing list<br>
<a moz-do-not-send="true"
href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a><br>
<a moz-do-not-send="true"
href="http://lists.freedesktop.org/mailman/listinfo/piglit"
target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>