<div dir="ltr">Ok, I just sent a patch to update sanity.py. I'm not really experienced in Python, so let me know if you have any problems with that patch. It ran on my machine.<br><br>Laura<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 20, 2014 at 8:48 PM, Michel Dänzer <span dir="ltr"><<a href="mailto:michel@daenzer.net" target="_blank">michel@daenzer.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 21.10.2014 07:49, Laura Ekstrand wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks for the catch. I took a look at sanity.py, and though I don't<br>
know much Python yet, it looks like there are only two tests in there.<br>
The Glean basic test will get deleted soon because my ultimate goal is<br>
to get rid of Glean altogether. Since readPixSanity is the only other<br>
test, do we really need sanity.py anymore?<br>
</blockquote>
<br></span>
sanity.py has been useful for bringing up a new driver (or new hardware with an existing driver): As long as sanity.py doesn't pass, one doesn't need to bother running any of the complete profiles, as the results may not be reliable. I'm not sure that the glean basic test needs to be replaced with anything for that purpose, but it might be nice to keep sanity.py even just for the test you added in patch 1.<div class="HOEnZb"><div class="h5"><br>
<br>
<br>
-- <br>
Earthling Michel Dänzer | <a href="http://www.amd.com" target="_blank">http://www.amd.com</a><br>
Libre software enthusiast | Mesa and X developer<br>
</div></div></blockquote></div><br></div>