<div dir="ltr">Looks good to me.<br><div><br></div>Reviewed-by: Laura Ekstrand <<a href="mailto:laura@jlekstrand.net">laura@jlekstrand.net</a><a href="mailto:jason.ekstrand@intel.com" target="_blank"></a>><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 7, 2014 at 2:52 PM, Vinson Lee <span dir="ltr"><<a href="mailto:vlee@freedesktop.org" target="_blank">vlee@freedesktop.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Silences GCC unused-function warnings.<br>
<br>
fpexceptions.c:149:1: warning: ‘make_denorm_double’ defined but not used [-Wunused-function]<br>
make_denorm_double(double *dest, int sign, int mantissa)<br>
^<br>
fpexceptions.c:167:1: warning: ‘make_signaling_nan_double’ defined but not used [-Wunused-function]<br>
make_signaling_nan_double(double *dest)<br>
^<br>
fpexceptions.c:173:1: warning: ‘make_quiet_nan_double’ defined but not used [-Wunused-function]<br>
make_quiet_nan_double(double *dest)<br>
^<br>
<br>
Signed-off-by: Vinson Lee <<a href="mailto:vlee@freedesktop.org">vlee@freedesktop.org</a>><br>
---<br>
tests/spec/gl-1.0/fpexceptions.c | 4 ++++<br>
1 file changed, 4 insertions(+)<br>
<br>
diff --git a/tests/spec/gl-1.0/fpexceptions.c b/tests/spec/gl-1.0/fpexceptions.c<br>
index 5df59fc..bee6258 100644<br>
--- a/tests/spec/gl-1.0/fpexceptions.c<br>
+++ b/tests/spec/gl-1.0/fpexceptions.c<br>
@@ -145,11 +145,13 @@ make_quiet_nan_float(float *dest)<br>
make_float(dest, 0, 255, 1 << 22);<br>
}<br>
<br>
+#if 0<br>
static void<br>
make_denorm_double(double *dest, int sign, int mantissa)<br>
{<br>
/* XXX to do */<br>
}<br>
+#endif<br>
<br>
static void<br>
make_pos_inf_double(double *dest)<br>
@@ -163,6 +165,7 @@ make_neg_inf_double(double *dest)<br>
*dest = -HUGE_VAL;<br>
}<br>
<br>
+#if 0<br>
static void<br>
make_signaling_nan_double(double *dest)<br>
{<br>
@@ -174,6 +177,7 @@ make_quiet_nan_double(double *dest)<br>
{<br>
/* XXX to do */<br>
}<br>
+#endif<br>
<br>
<br>
/* Uncomment to test float production */<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.9.1<br>
<br>
_______________________________________________<br>
Piglit mailing list<br>
<a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a><br>
</font></span></blockquote></div><br></div>