<div dir="ltr"><div>Sure, fine by me </div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com">jason.ekstrand@intel.com</a>> </div><div class="gmail_extra"> <div class="gmail_quote">On Fri, Nov 7, 2014 at 3:11 PM, Vinson Lee <<a href="mailto:vlee@freedesktop.org" target="_blank">vlee@freedesktop.org</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Fixes GCC maybe-uninitialized warning. formats.c:560:11: warning: 'gtype' may be used uninitialized in this function [-Wmaybe-uninitialized] snprintf(fs_src, sizeof(ms_compare_fs_source), ^ Signed-off-by: Vinson Lee <<a href="mailto:vlee@freedesktop.org">vlee@freedesktop.org</a>> --- tests/spec/arb_copy_image/formats.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/arb_copy_image/formats.c b/tests/spec/arb_copy_image/formats.c index 92715ba..8a5faa7 100644 --- a/tests/spec/arb_copy_image/formats.c +++ b/tests/spec/arb_copy_image/formats.c @@ -551,6 +551,7 @@ load_compare_program(struct texture_format *format) gtype = "i"; } else { assert(!"Invalid comparison fucntion"); + gtype = ""; } /* The generated source will be shorter because we replace -- 1.9.3 _______________________________________________ Piglit mailing list <a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a> </blockquote></div> </div>