<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 13, 2015 at 2:24 AM, Samuel Iglesias Gonsálvez <span dir="ltr"><<a href="mailto:siglesias@igalia.com" target="_blank">siglesias@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Monday, January 12, 2015 01:14:23 PM Jason Ekstrand wrote:<br>
> Since GL_ABGR_EXT was extension number 1 to the GL spec, it didn't take<br>
> packed formats into account. As far as I can tell from the way the packed<br>
> formats extensions are written, packed formats with GL_ABGR_EXT isn't<br>
> allowed by the spec. NVIDIA allows it but AMD doesn't and our driver<br>
> hasn't allowed ith with UNSIGNED_INT_5_5_5_1 as of c471b09bf4. Let's stop<br>
> testing invalid things.<br>
<br>
</span>Reviewed-by: Samuel Iglesias Gonsalvez <<a href="mailto:siglesias@igalia.com">siglesias@igalia.com</a>><br></blockquote><div><br></div><div>Thans, Sam. Pushed.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
I sent yesterday morning a similar patch [0] that also stop testing those<br>
GL_ABGR_EXT format and type combinations in texture-packed-formats.c and<br>
tests/glean/tpixelformats.cpp.<br>
<br>
As your patch is more complete than mine for texture-packed-formats.c , I am<br>
going to modify mine and resend it once you have pushed this patch to master.<br>
<br>
Sam<br>
<br>
[0] <a href="http://lists.freedesktop.org/archives/piglit/2015-January/014052.html" target="_blank">http://lists.freedesktop.org/archives/piglit/2015-January/014052.html</a><br>
<div class="HOEnZb"><div class="h5"><br>
> ---<br>
> tests/texturing/texture-packed-formats.c | 13 -------------<br>
> 1 file changed, 13 deletions(-)<br>
><br>
> diff --git a/tests/texturing/texture-packed-formats.c<br>
> b/tests/texturing/texture-packed-formats.c index 1c92b1c..87da808 100644<br>
> --- a/tests/texturing/texture-packed-formats.c<br>
> +++ b/tests/texturing/texture-packed-formats.c<br>
> @@ -89,19 +89,6 @@ static const struct pixel_format Formats[] = {<br>
> { "GL_BGRA/GL_UNSIGNED_SHORT_1_5_5_5_REV",<br>
> GL_BGRA, GL_UNSIGNED_SHORT_1_5_5_5_REV, 2, 0xfc00, 0x83e0 },<br>
><br>
> - { "GL_ABGR_EXT/GL_UNSIGNED_INT_8_8_8_8",<br>
> - GL_ABGR_EXT, GL_UNSIGNED_INT_8_8_8_8, 4, 0x800000ff, 0x8000ff00 },<br>
> - { "GL_ABGR_EXT/GL_UNSIGNED_INT_8_8_8_8_REV",<br>
> - GL_ABGR_EXT, GL_UNSIGNED_INT_8_8_8_8_REV, 4, 0xff000080, 0x00ff0080 },<br>
> - { "GL_ABGR_EXT/GL_UNSIGNED_SHORT_4_4_4_4",<br>
> - GL_ABGR_EXT, GL_UNSIGNED_SHORT_4_4_4_4, 2, 0x800f, 0x80f0 },<br>
> - { "GL_ABGR_EXT/GL_UNSIGNED_SHORT_4_4_4_4_REV",<br>
> - GL_ABGR_EXT, GL_UNSIGNED_SHORT_4_4_4_4_REV, 2, 0xf008, 0x0f08 },<br>
> - { "GL_ABGR_EXT/GL_UNSIGNED_SHORT_5_5_5_1",<br>
> - GL_ABGR_EXT, GL_UNSIGNED_SHORT_5_5_5_1, 2, 0xf801, 0xf83e },<br>
> - { "GL_ABGR_EXT/GL_UNSIGNED_SHORT_1_5_5_5_REV",<br>
> - GL_ABGR_EXT, GL_UNSIGNED_SHORT_1_5_5_5_REV, 2, 0x800f, 0x7c0f },<br>
> -<br>
> { "GL_RGB/GL_UNSIGNED_SHORT_5_6_5",<br>
> GL_RGB, GL_UNSIGNED_SHORT_5_6_5, 2, 0xf800, 0x7e0 },<br>
> { "GL_RGB/GL_UNSIGNED_SHORT_5_6_5_REV",<br>
</div></div></blockquote></div><br></div></div>