<div dir="ltr"><div>Looks good to me.<br><br></div>Reviewed-by: Laura Ekstrand <<a href="mailto:laura@jlekstrand.net">laura@jlekstrand.net</a>><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 5, 2015 at 4:47 PM, Brian Paul <span dir="ltr"><<a href="mailto:brianp@vmware.com" target="_blank">brianp@vmware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">---<br>
tests/spec/gl-1.0/blend.c | 20 ++++++++++++++++++--<br>
1 file changed, 18 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/tests/spec/gl-1.0/blend.c b/tests/spec/gl-1.0/blend.c<br>
index 9fe345c..065b8bb 100644<br>
--- a/tests/spec/gl-1.0/blend.c<br>
+++ b/tests/spec/gl-1.0/blend.c<br>
@@ -529,7 +529,7 @@ run_factor_set(GLenum src_factor_rgb, GLenum src_factor_a,<br>
const GLfloat constant_color[4])<br>
{<br>
int i, j;<br>
- bool pass = true;<br>
+ bool pass = true, p;<br>
<br>
glDisable(GL_DITHER);<br>
glClear(GL_COLOR_BUFFER_BIT);<br>
@@ -609,9 +609,25 @@ run_factor_set(GLenum src_factor_rgb, GLenum src_factor_a,<br>
* computed image (``expected'') to see if any pixels are<br>
* outside the expected tolerance range.<br>
*/<br>
- pass &= piglit_probe_image_rgba(0, 0, img_width, img_height,<br>
+ p = piglit_probe_image_rgba(0, 0, img_width, img_height,<br>
exp_img.data);<br>
+ if (!p) {<br>
+ printf(" Blend src factors: %s, %s\n",<br>
+ piglit_get_gl_enum_name(src_factor_rgb),<br>
+ piglit_get_gl_enum_name(src_factor_a));<br>
+ printf(" Blend dst factors: %s, %s\n",<br>
+ piglit_get_gl_enum_name(dst_factor_rgb),<br>
+ piglit_get_gl_enum_name(dst_factor_a));<br>
+ printf(" Blend ops: %s, %s\n",<br>
+ piglit_get_gl_enum_name(op_rgb),<br>
+ piglit_get_gl_enum_name(op_a));<br>
+ printf(" Blend color: %.3f, %.3f, %.3f, %.3f\n",<br>
+ constant_color[0], constant_color[1],<br>
+ constant_color[2], constant_color[3]);<br>
+ fflush(stdout);<br>
+ }<br>
<br>
+ pass &= p;<br>
<br>
return pass;<br>
} /* run_factor_set */<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.9.1<br>
<br>
_______________________________________________<br>
Piglit mailing list<br>
<a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a><br>
</font></span></blockquote></div><br></div>