<div dir="ltr">I'd be fine with reverting that patch in that case. If you want to do it you can add my acked</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 23, 2015 at 8:40 PM, Michel Dänzer <span dir="ltr"><<a href="mailto:michel@daenzer.net" target="_blank">michel@daenzer.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Hi Dylan,<br>
<div><div class="h5"><br>
<br>
On <a href="tel:21.02.2015%2011" value="+12102201511">21.02.2015 11</a>:18, Dylan Baker wrote:<br>
> It really doesn't make sense to have static tests in the generated tests<br>
> directory, this patch adds them to the tests directory and adds the<br>
> appropriate code to cl.py for this change<br>
><br>
> Signed-off-by: Dylan Baker <<a href="mailto:dylanx.c.baker@intel.com">dylanx.c.baker@intel.com</a>><br>
> ---<br>
>  tests/cl.py                                                  | 2 ++<br>
>  {generated_tests => tests}/cl/store/store-kernels-global.inc | 0<br>
>  {generated_tests => tests}/cl/store/store-kernels-local.inc  | 0<br>
>  3 files changed, 2 insertions(+)<br>
>  rename {generated_tests => tests}/cl/store/store-kernels-global.inc (100%)<br>
>  rename {generated_tests => tests}/cl/store/store-kernels-local.inc (100%)<br>
><br>
> diff --git a/tests/cl.py b/tests/cl.py<br>
> index 06301af..bc7c63f 100644<br>
> --- a/tests/cl.py<br>
> +++ b/tests/cl.py<br>
> @@ -167,3 +167,5 @@ program_execute_store = {}<br>
>  program["Execute"]["Store"] = program_execute_store<br>
>  add_program_test_dir(program_execute_store,<br>
>                       os.path.join(GENERATED_TESTS_DIR, 'cl', 'store'))<br>
> +add_program_test_dir(program_execute_store,<br>
> +                     os.path.join(TESTS_DIR, 'cl', 'store'))<br>
> diff --git a/generated_tests/cl/store/store-kernels-global.inc b/tests/cl/store/store-kernels-global.inc<br>
> similarity index 100%<br>
> rename from generated_tests/cl/store/store-kernels-global.inc<br>
> rename to tests/cl/store/store-kernels-global.inc<br>
> diff --git a/generated_tests/cl/store/store-kernels-local.inc b/tests/cl/store/store-kernels-local.inc<br>
> similarity index 100%<br>
> rename from generated_tests/cl/store/store-kernels-local.inc<br>
> rename to tests/cl/store/store-kernels-local.inc<br>
><br>
<br>
</div></div>This change broke some CL tests:<br>
<br>
Program source file<br>
/home/daenzer/src/piglit-git/piglit/generated_tests/cl/store/store-kernels-global.inc<br>
does not exists or is empty<br>
<br>
I'm working around this for now with these symlinks:<br>
<br>
generated_tests/cl/store/store-kernels-global.inc: symbolic link to<br>
../../../tests/cl/store/store-kernels-global.inc<br>
generated_tests/cl/store/store-kernels-local.inc:  symbolic link to<br>
../../../tests/cl/store/store-kernels-local.inc<br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
--<br>
Earthling Michel Dänzer               |               <a href="http://www.amd.com" target="_blank">http://www.amd.com</a><br>
Libre software enthusiast             |             Mesa and X developer<br>
</font></span></blockquote></div><br></div>