<div dir="ltr">Reviewed-by: Laura Ekstrand <<a href="mailto:laura@jlekstrand.net">laura@jlekstrand.net</a>><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 3, 2015 at 6:26 PM, Vinson Lee <span dir="ltr"><<a href="mailto:vlee@freedesktop.org" target="_blank">vlee@freedesktop.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">readpix.c:238:10: warning: using integer absolute value function 'abs' when argument is of floating point type [-Wabsolute-value]<br>
dd = abs(actual - expected);<br>
^<br>
readpix.c:238:10: note: use function 'fabs' instead<br>
dd = abs(actual - expected);<br>
^~~<br>
fabs<br>
<br>
Signed-off-by: Vinson Lee <<a href="mailto:vlee@freedesktop.org">vlee@freedesktop.org</a>><br>
---<br>
tests/spec/gl-1.0/readpix.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/tests/spec/gl-1.0/readpix.c b/tests/spec/gl-1.0/readpix.c<br>
index 9597706..a2822b4 100644<br>
--- a/tests/spec/gl-1.0/readpix.c<br>
+++ b/tests/spec/gl-1.0/readpix.c<br>
@@ -235,7 +235,7 @@ check_depth(void)<br>
for (y = 0; y < h; ++y) {<br>
for (x = 0; x < w; ++x) {<br>
actual = buf[y*w + x]/(double)0xffffffffU;<br>
- dd = abs(actual - expected);<br>
+ dd = fabs(actual - expected);<br>
err = error_bits(dd, dbits);<br>
if (err > current_error) {<br>
current_error = err;<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.3.1<br>
<br>
_______________________________________________<br>
Piglit mailing list<br>
<a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a><br>
</font></span></blockquote></div><br></div>