<div dir="ltr">Reviewed-by: Laura Ekstrand <<a href="mailto:laura@jlekstrand.net">laura@jlekstrand.net</a>> </div><div class="gmail_extra"> <div class="gmail_quote">On Tue, Mar 3, 2015 at 6:07 PM, Vinson Lee <<a href="mailto:vlee@freedesktop.org" target="_blank">vlee@freedesktop.org</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">getcompressedtextureimage.c:121:7: warning: using floating point absolute value function 'fabs' when argument is of integer type [-Wabsolute-value] if (fabs((int)data[i] - (int)expected[i]) > tolerance) { ^ getcompressedtextureimage.c:121:7: note: use function 'abs' instead if (fabs((int)data[i] - (int)expected[i]) > tolerance) { ^~~~ abs Signed-off-by: Vinson Lee <<a href="mailto:vlee@freedesktop.org">vlee@freedesktop.org</a>> --- tests/spec/arb_direct_state_access/getcompressedtextureimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/arb_direct_state_access/getcompressedtextureimage.c b/tests/spec/arb_direct_state_access/getcompressedtextureimage.c index 9546af5..84aa30b 100644 --- a/tests/spec/arb_direct_state_access/getcompressedtextureimage.c +++ b/tests/spec/arb_direct_state_access/getcompressedtextureimage.c @@ -118,7 +118,7 @@ compare_layer(int layer, int num_elements, int tolerance, int i; for (i = 0; i < num_elements; ++i) { - if (fabs((int)data[i] - (int)expected[i]) > tolerance) { + if (abs((int)data[i] - (int)expected[i]) > tolerance) { printf("GetCompressedTextureImage() returns incorrect" " data in byte %i for layer %i\n", i, layer); -- 2.3.1 _______________________________________________ Piglit mailing list <a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a> </blockquote></div> </div>