<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 16, 2015 at 1:23 PM, Ilia Mirkin <span dir="ltr"><<a href="mailto:imirkin@alum.mit.edu" target="_blank">imirkin@alum.mit.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">[please make sure to keep lists in cc] </blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div><div class="h5"><br>
On Mon, Mar 16, 2015 at 1:14 PM, Aditya Avinash<br>
<<a href="mailto:adityaavinash1@gmail.com">adityaavinash1@gmail.com</a>> wrote:<br>
><br>
><br>
> On Mon, Mar 16, 2015 at 11:36 AM, Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu">imirkin@alum.mit.edu</a>> wrote:<br>
>><br>
>> On Mon, Mar 16, 2015 at 11:16 AM, Aditya Atluri<br>
>> <<a href="mailto:adityaavinash1@gmail.com">adityaavinash1@gmail.com</a>> wrote:<br>
>> > ---<br>
>> > tests/all.py | 5 ++<br>
>> > tests/spec/CMakeLists.txt | 1 +<br>
>> > .../CMakeLists.gl.txt | 15 +++++<br>
>> > .../CMakeLists.txt | 1 +<br>
>> > .../spec/arb_shader_storage_buffer_object/minmax.c | 67<br>
>> > ++++++++++++++++++++++<br>
>> > 5 files changed, 89 insertions(+)<br>
>> > create mode 100644<br>
>> > tests/spec/arb_shader_storage_buffer_object/CMakeLists.gl.txt<br>
>> > create mode 100644<br>
>> > tests/spec/arb_shader_storage_buffer_object/CMakeLists.txt<br>
>> > create mode 100644 tests/spec/arb_shader_storage_buffer_object/minmax.c<br>
>> ><br>
>> > diff --git a/tests/all.py b/tests/all.py<br>
>> > index 1c3c889..49ae468 100644<br>
>> > --- a/tests/all.py<br>
>> > +++ b/tests/all.py<br>
>> > @@ -3964,6 +3964,11 @@ with profile.group_manager(<br>
>> ><br>
>> > with profile.group_manager(<br>
>> > PiglitGLTest,<br>
>> > + grouptools.join('spec', 'arb_shader_storage_buffer_object')) as<br>
>> > g:<br>
>> > + g(['arb_shader_storage_buffer_object-minmax'], 'minmax')<br>
>><br>
>> I think you want run_concurrent=True here as well.<br>
><br>
><br>
> Sure.<br>
><br>
>><br>
>><br>
>> > +<br>
>> > +with profile.group_manager(<br>
>> > + PiglitGLTest,<br>
>> > grouptools.join('spec', 'ext_polygon_offset_clamp')) as g:<br>
>> > g(['ext_polygon_offset_clamp-draw'], run_concurrent=True)<br>
>> > g(['ext_polygon_offset_clamp-dlist'], run_concurrent=True)<br>
>> > diff --git a/tests/spec/CMakeLists.txt b/tests/spec/CMakeLists.txt<br>
>> > index 7423589..a680c1b 100644<br>
>> > --- a/tests/spec/CMakeLists.txt<br>
>> > +++ b/tests/spec/CMakeLists.txt<br>
>> > @@ -84,6 +84,7 @@ add_subdirectory (arb_vertex_array_bgra)<br>
>> > add_subdirectory (arb_vertex_buffer_object)<br>
>> > add_subdirectory (arb_vertex_program)<br>
>> > add_subdirectory (arb_copy_buffer)<br>
>> > +add_subdirectory (arb_shader_storage_buffer_object)<br>
>> > add_subdirectory (glsl-1.10)<br>
>> > add_subdirectory (glsl-1.20)<br>
>> > add_subdirectory (glsl-1.30)<br>
>> > diff --git<br>
>> > a/tests/spec/arb_shader_storage_buffer_object/CMakeLists.gl.txt<br>
>> > b/tests/spec/arb_shader_storage_buffer_object/CMakeLists.gl.txt<br>
>> > new file mode 100644<br>
>> > index 0000000..d2a9d87<br>
>> > --- /dev/null<br>
>> > +++ b/tests/spec/arb_shader_storage_buffer_object/CMakeLists.gl.txt<br>
>> > @@ -0,0 +1,15 @@<br>
>> > +include_directories(<br>
>> > + ${GLEXT_INCLUDE_DIR}<br>
>> > + ${OPENGL_INCLUDE_PATH}<br>
>> > + ${piglit_SOURCE_DIR}/tests/util<br>
>><br>
>> Is this last line necessary? In another test, I didn't need it...<br>
><br>
><br>
> I think it's for "piglit-util-gl.h"<br>
<br>
</div></div>Try without it. I think that's already taken care of.<br></blockquote><div><br></div><div>Yes it is. :)<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span class=""><br>
><br>
>><br>
>><br>
>> > +)<br>
>> > +<br>
>> > +link_libraries (<br>
>> > + piglitutil_${piglit_target_api}<br>
>> > + ${OPENGL_gl_LIBRARY}<br>
>> > + ${OPENGL_glu_LIBRARY}<br>
>><br>
>> Why do you need glu here?<br>
><br>
><br>
> I borrowed it from arb_compute_shader tests. Do you want me to remove from<br>
> compute shaders too?<br>
<br>
</span>Don't worry about cleaning up other people's stuff.<br></blockquote><div><br></div><div>Ok! Removing them is not changing the test behaviour. (for compute shaders too)<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span class=""><br>
>> > + piglit_test_min_int64(GL_MAX_SHADER_STORAGE_BLOCK_SIZE,<br>
>> > 134217728); // 2^27<br>
>><br>
>> This was right before with 2^24. I just checked in the GL core spec,<br>
>> and it also has 2^24 just like in the extension. Why did you change<br>
>> it?<br>
><br>
><br>
> The extension spec specifies 2^24 but 4.5 spec specifies 2^27.<br>
<br>
</span>Hrmph. GL 4.4 still has it at 2^24. Just do 2^24 here... or if you<br>
feel like being fancy, you could do<br>
<br>
if (piglit_get_gl_version() >= 45)<br>
high limit<br>
else<br>
low limit<br></blockquote><div>I'll just leave it like that. <br></div></div><br><br clear="all"><br>-- <br><div class="gmail_signature"><div dir="ltr"><div><div><font style="font-family:trebuchet ms,sans-serif">Regards,<br></font></div><font style="font-family:trebuchet ms,sans-serif"><b style="background-color:rgb(255,255,255);color:rgb(0,0,153)">Aditya Atluri,<br></b></font></div><div><font style="font-family:trebuchet ms,sans-serif"><b style="background-color:rgb(255,255,255);color:rgb(0,0,153)">USA.<br></b></font></div><font style="font-family:trebuchet ms,sans-serif"><b style="background-color:rgb(255,255,255);color:rgb(0,0,153)"></b><span style="background-color:rgb(255,255,255);color:rgb(0,0,153)"></span></font><br></div></div>
</div></div>