<div dir="ltr"><div>Bump. The driver functionality is upstreamed, so I'm planning on pushing these tests next Monday.<br><br></div>Martin:
There's another, separate test for CreateBuffers that I sent out a
couple of weeks ago that addresses your concerns here.</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 18, 2015 at 6:45 AM, Martin Peres <span dir="ltr"><<a href="mailto:martin.peres@linux.intel.com" target="_blank">martin.peres@linux.intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Please check that a buffer returned by glCreateBuffers will return true when passed as a parameter of IsBuffer();<br>
Please also check that negative n return INVALID_VALUE.<br>
<br>
For these reasons, I decided to create the create-*.c tests for all the create functions. One could argue that they<br>
could all be folded into the same file now that I think of it...<div class="HOEnZb"><div class="h5"><br>
<br>
On 23/01/15 21:03, Laura Ekstrand wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
tests/spec/arb_direct_state_<u></u>access/<u></u>getcompressedtextureimage.c | 2 +-<br>
tests/spec/arb_direct_state_<u></u>access/texture-buffer-range.c | 2 +-<br>
tests/spec/arb_direct_state_<u></u>access/texture-buffer.c | 2 +-<br>
3 files changed, 3 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/tests/spec/arb_direct_state_<u></u>access/<u></u>getcompressedtextureimage.c b/tests/spec/arb_direct_state_<u></u>access/<u></u>getcompressedtextureimage.c<br>
index 9546af5..0d72df4 100644<br>
--- a/tests/spec/arb_direct_state_<u></u>access/<u></u>getcompressedtextureimage.c<br>
+++ b/tests/spec/arb_direct_state_<u></u>access/<u></u>getcompressedtextureimage.c<br>
@@ -224,7 +224,7 @@ getTexImage(bool doPBO, GLenum target, GLubyte *data,<br>
/* Setup the PBO or data array to read into from<br>
* glGetCompressedTextureImage */<br>
if (doPBO) {<br>
- glGenBuffers(1, &packPBO);<br>
+ glCreateBuffers(1, &packPBO);<br>
glBindBuffer(GL_PIXEL_PACK_<u></u>BUFFER, packPBO);<br>
/* Make the buffer big enough to hold uncompressed data. */<br>
glBufferData(GL_PIXEL_PACK_<u></u>BUFFER, layer_size * num_faces *<br>
diff --git a/tests/spec/arb_direct_state_<u></u>access/texture-buffer-range.c b/tests/spec/arb_direct_state_<u></u>access/texture-buffer-range.c<br>
index 859000e..49c835a 100644<br>
--- a/tests/spec/arb_direct_state_<u></u>access/texture-buffer-range.c<br>
+++ b/tests/spec/arb_direct_state_<u></u>access/texture-buffer-range.c<br>
@@ -135,7 +135,7 @@ piglit_init(int argc, char **argv) {<br>
glGenVertexArrays(1, &vao);<br>
glBindVertexArray(vao);<br>
- glGenBuffers(1, &tbo);<br>
+ glCreateBuffers(1, &tbo);<br>
glBindBuffer(GL_ARRAY_BUFFER, tbo);<br>
glBufferData(GL_ARRAY_BUFFER, sizeof(data), data, GL_STATIC_DRAW);<br>
diff --git a/tests/spec/arb_direct_state_<u></u>access/texture-buffer.c b/tests/spec/arb_direct_state_<u></u>access/texture-buffer.c<br>
index 1246071..47f694f 100644<br>
--- a/tests/spec/arb_direct_state_<u></u>access/texture-buffer.c<br>
+++ b/tests/spec/arb_direct_state_<u></u>access/texture-buffer.c<br>
@@ -70,7 +70,7 @@ piglit_display(void)<br>
prog = piglit_build_simple_program(<u></u>vs_source, fs_source);<br>
glUseProgram(prog);<br>
- glGenBuffers(1, &bo);<br>
+ glCreateBuffers(1, &bo);<br>
glBindBuffer(GL_TEXTURE_<u></u>BUFFER, bo);<br>
glBufferData(GL_TEXTURE_<u></u>BUFFER, sizeof(g_rgba8), g_rgba8,<br>
GL_STREAM_DRAW);<br>
</blockquote>
<br>
</div></div></blockquote></div><br></div>